Attention is currently required from: Andrey Pronin, Raul Rangel, Paul Menzel, Julius Werner, Yu-Ping Wu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59476 )
Change subject: src/security/vboot: Set up secure counter space in TPM NVRAM
......................................................................
Patch Set 3:
(3 comments)
File src/security/vboot/antirollback.h:
https://review.coreboot.org/c/coreboot/+/59476/comment/2f7f66bc_fc224c92
PS2, Line 30: #define HASH_NV_SIZE VB2_SHA256_DIGEST_SIZE
I would insert them here so the spaces are listed in ascending order. […]
Done
https://review.coreboot.org/c/coreboot/+/59476/comment/c7e28066_2fe074db
PS2, Line 42: #define SECURE_COUNTER4_NV_INDEX 0x1012
right, but the indexes of the counters are cr50 specific. […]
I have made references to use-case here(Widevine) so that it is more clear.
File src/security/vboot/secure_counter.h:
https://review.coreboot.org/c/coreboot/+/59476/comment/de8222c9_930790b3
PS1, Line 14: SECURE_COUNTER4_NV_INDEX, /* 0x1012 */
No, I think the counters should be specifically named after their purpose. […]
Ack. Rephrased the kconfig item, macros etc. to make it clear that this is specific to Widevine Counters.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59476
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I915fbdada60e242d911b748ad5dc28028de9b657
Gerrit-Change-Number: 59476
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Andrey Pronin
apronin@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Pronin
apronin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Andrey Pronin
apronin@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Andrey Pronin
apronin@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Sat, 20 Nov 2021 00:20:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment