Attention is currently required from: Martin L Roth, Julius Werner, Angel Pons.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68545 )
Change subject: console: Add a 32-bit vendor post-code call ......................................................................
Patch Set 2:
(1 comment)
File src/console/post.c:
https://review.coreboot.org/c/coreboot/+/68545/comment/53784421_c8a0951c PS1, Line 22: uint32_t
One of those patches comes immediately after this, and more are coming. […]
You're absolutely right about the following patch, currently it only needs to be 8-bit.
Yes, I have some other code that was calling soc_post_code() directly, but it's not ready to post yet.
Really, my desire is to update coreboot's entire post-code system, which is kind of a disaster right now in my opinion. I've mentioned this before at a leadership meeting, but I haven't had the time to finish redesigning it.
The soc_post_code() function above was part of that redesign that I pulled in for this specific feature.
If you want, I can update it to 8-bit for now, and expand it to 32-bits later as part of the overall redesign.
-
Martin Roth (Code Review)