Attention is currently required from: Martin Roth, Matt DeVillier.
Jon Murphy has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83606?usp=email )
Change subject: mb/google/dedede/var/galtic: Add fw_config option for touchpad type
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/dedede/variants/galtic/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83606/comment/20bfd294_77de5b85?usp... :
PS1, Line 12: TOUCHPAD_SOURCE 44 45
Unless Google actually makes this change as well, setting it as the next bits in the bitfield could […]
+1 on the upper bits. I'll look at what is allocated internally and provide feedback or reserve fields.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83606?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I36797eb5c8f262782380f95ff3c2e38443cf00c0
Gerrit-Change-Number: 83606
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jon Murphy
jpmurphy@google.com
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Mon, 22 Jul 2024 18:22:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com