Attention is currently required from: Derek Huang, Shou-Chieh Hsu, Tarun Tuli.
Terry Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75914?usp=email )
Change subject: mb/google/nissa/var/joxer: Update Joxer GPIO
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/brya/variants/joxer/gpio.c:
https://review.coreboot.org/c/coreboot/+/75914/comment/1c0811ac_fead28c6 :
PS3, Line 46: PAD_NC
PAD_NC_LOCK(GPP_H12, NONE, LOCK_CONFIG),
Done
https://review.coreboot.org/c/coreboot/+/75914/comment/2dda6f2a_3bac9a19 :
PS3, Line 48: PAD_NC(GPP_H13, NONE),
same as above
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75914?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a55058b453771d264700a1364ef538f831148e4
Gerrit-Change-Number: 75914
Gerrit-PatchSet: 4
Gerrit-Owner: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Zoey Wu
zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Mon, 19 Jun 2023 07:47:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Derek Huang
derekhuang@google.com
Gerrit-MessageType: comment