[M] Change in coreboot[master]: mb/google/nissa/var/craask: Disable storage devices based on fw_config - coreboot-gerrit

9 Jan 2023


      Attention is currently required from: Tarun Tuli, Kangheui Won, Reka Norman, Ren Kuo.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71726 )
Change subject: mb/google/nissa/var/craask: Disable storage devices based on fw_config
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/brya/variants/craask/variant.c:
https://review.coreboot.org/c/coreboot/+/71726/comment/23489a99_a48faa8e 
PS1, Line 24: 	if (!fw_config_probe(FW_CONFIG(STORAGE, STORAGE_EMMC))) {
Will emmc turn off by pci scan?
https://review.coreboot.org/c/coreboot/+/71726/comment/fefff00c_4c285766 
PS1, Line 31: 		nvme_rp->enabled = 0;
This will turn off by pci scan.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/71726
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4167ee4d00b9ae8fe074c6f5e7a2d5a7382bfe6d
Gerrit-Change-Number: 71726
Gerrit-PatchSet: 1
Gerrit-Owner: Reka Norman rekanorman@chromium.org
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Ren Kuo ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Reka Norman rekanorman@google.com
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Kangheui Won khwon@chromium.org
Gerrit-Attention: Reka Norman rekanorman@chromium.org
Gerrit-Attention: Ren Kuo ren.kuo@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 09 Jan 2023 06:05:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment