Attention is currently required from: Benjamin Doron, Jean Lucas, Lean Sheng Tan, Martin L Roth, Nico Huber, Sean Rhodes.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82000?usp=email )
Change subject: paylods/edk2: Add Kconfig to use LAPIC timer
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/northbridge/intel/gm45/Kconfig:
https://review.coreboot.org/c/coreboot/+/82000/comment/521c6de6_14fd4c9e :
PS3, Line 52: config EDK2_USE_LAPIC_TIMER
AIUI, this is an aspect of the processor and could hit devices with other […]
+1, as these CPUs are also used with the i945 and x4x northbridges.
Maybe `model_106cx` (Diamondville and Pineview, the early Atoms) would also need this, but we should wait until someone tests it (I don't think there's any board that comes with a large enough flash chip to fit edk2).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82000?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I33144d6c1c120e7faa47b99e8262b0997c45c9b9
Gerrit-Change-Number: 82000
Gerrit-PatchSet: 3
Gerrit-Owner: Jean Lucas
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Jean Lucas
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Fri, 19 Apr 2024 15:02:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment