Change in coreboot[master]: soc/intel/elkhartlake: Introduce Intel PSE

[Nico Huber (Code Review)]

Attention is currently required from: Arthur Heymans, Maulik V Vaghela, Paul Menzel, Mario Scheithauer, Angel Pons, Subrata Banik, Michael Niewöhner, Lean Sheng Tan, Werner Zeh, Patrick Rudolph, Felix Held.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55367 )

Change subject: soc/intel/elkhartlake: Introduce Intel PSE
......................................................................

Patch Set 49:

(3 comments)

File src/soc/intel/elkhartlake/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/55367/comment/8ea7e29f_b91df4af 
PS49, Line 66:
> > Well, no better solution from the top of my head, and I'm not paid […]

Well it's not the common coreboot practice. This is not the
only case where a blob option exists, should be build tested
but no blob is available. Making the file optional and warn
if it isn't added is the usual, accepted approach AFAIK.

A TODO would be good enough for a neutral (0 score) review
from my side.

File src/soc/intel/elkhartlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/55367/comment/6d5744cd_030a752e 
PS49, Line 385: FSP_ARRAY_LOAD
> > > I do not see exactly how the macro itself hides the types from memcpy().
> >
> > It doesn't, I said it hides the implementation (hides that memcpy() is used).
>
> OK, I see.
> > > From gcc's point of view
> >
> > I'm more concerned about the reviewers and human readers point of view.
>
> The former version of it was even worse readable for the reviewer. So I guess the macro at least increases readability with the burden that the reader needs to know its implementation.

Plus the burden to decide to either accept the bad implementation or
ask the author to fix the macro they are using.

File src/soc/intel/elkhartlake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/55367/comment/c1b44fab_c034541d 
PS49, Line 127: 	m_cfg->PchPseEnable = CONFIG(PSE_ENABLE);
> Do we have a CBFS API that can check for a file without loading it?

I don't know.