Attention is currently required from: Martin Roth, Andy Yeh, Sugnan Prabhu S, Rizwan Qureshi. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50261 )
Change subject: mb/google/dedede/var/magolor: Enable dynamic SSDT generation ......................................................................
Patch Set 9:
(5 comments)
File src/mainboard/google/dedede/variants/magolor/camera_config.c:
PS9: I think most of this can be handled in the overridetree.cb. Please see my comments in that file.
File src/mainboard/google/dedede/variants/magolor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/50261/comment/8234aeb4_17e85f21 PS9, Line 117: chip drivers/intel/mipi_camera The registers here seem to be the same for both cameras used for Magolor. So, I think this can remain the same in override tree.
https://review.coreboot.org/c/coreboot/+/50261/comment/d8c486f6_d5a0c0df PS9, Line 205: chip drivers/intel/mipi_camera If I am reading camera_config.c correctly, this is the only device that is really different between the two camera types. It should be possible to handle this completely in overridetree by using "probe" statements. This is what it will look like:
``` device pci 15.3 on chip drivers/intel/mipi_camera register "acpi_hid" = ""OVTI5675"" ... device i2c 36 on end probe CAMERA CAMERA_OVTI5675 end chip drivers/intel/mipi_camera register "acpi_hid" = ""OVTI8856"" ... device i2c 36 on end probe CAMERA CAMERA_OVTI8856 end ... end ```
FW_CONFIG infrastructure will take care of enabling the right device based on how FW_CONFIG/SSFC is provisioned.
The options that I mentioned in `probe` statements above are just some dummy names I made up. But, you will have to update the field and options here: https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...
https://review.coreboot.org/c/coreboot/+/50261/comment/2fb0056e_54fab9e9 PS9, Line 246: chip drivers/intel/mipi_camera Looks like the VCM is the same for both cameras. So, this can stay as is in the override tree.
https://review.coreboot.org/c/coreboot/+/50261/comment/489cb8a5_85705259 PS9, Line 258: chip drivers/intel/mipi_camera Looks like NVM is also the same for both cameras. So, this can stay as is in the override tree.