Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60398 )
Change subject: mb/google/corsola: Initialize kingler display
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/60398/comment/05a69fff_e76e4043
PS1, Line 110: (void)
no need to add this (void) ?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60398
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie8de5d8ba150d3ae086c7635601dbc0846aebe91
Gerrit-Change-Number: 60398
Gerrit-PatchSet: 2
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 27 Dec 2021 09:01:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment