Attention is currently required from: Bora Guvendik, Michał Żygowski, Name of user not set #1004406, Paul Menzel, Subrata Banik, Tim Crawford.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69798?usp=email )
Change subject: soc/intel/alderlake: Add support for Raptor Lake S CPUs ......................................................................
Patch Set 12:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69798/comment/a388bbbc_b2bd7e3a : PS11, Line 10: DOCs
docs
Done
https://review.coreboot.org/c/coreboot/+/69798/comment/455d443e_86a8e8b9 : PS11, Line 13: LinuxBoot
Does that mean Linux kernel and u-root?
Yes, added to the commit message
https://review.coreboot.org/c/coreboot/+/69798/comment/271cc5d9_a2cc6d8b : PS11, Line 14:
What CPU did you test with?
Added CPUs to the commit message
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/69798/comment/c929396a_aae79781 : PS10, Line 182: { PCI_DID_INTEL_ADL_S_ID_12, RPL_S_201_65W_CORE, TDP_65W }
Fixed the build problems, still need to retest with all the changes...
Acknowledged
File src/soc/intel/common/block/lpc/lpc.c:
https://review.coreboot.org/c/coreboot/+/69798/comment/11bb5ad2_eb44b65b : PS11, Line 185: PCI_DID_INTEL_RPP_S_ESPI_Z790, : PCI_DID_INTEL_RPP_S_ESPI_H770, : PCI_DID_INTEL_RPP_S_ESPI_B760,
Please mention this in the commit message, or even make the rename a separate commit.
Reverted the name change