[M] Change in coreboot[master]: mb/google/skyrim: Use CMOS bit to toggle ABL WA for Hynix DRAM

[Martin Roth (Code Review)]

Attention is currently required from: Felix Held, Jason Glenesk, Jason Nien, Karthik Ramasubramanian, Matt DeVillier.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75698?usp=email )

Change subject: mb/google/skyrim: Use CMOS bit to toggle ABL WA for Hynix DRAM
......................................................................

Patch Set 2:

(3 comments)

File src/mainboard/google/skyrim/bootblock.c:

https://review.coreboot.org/c/coreboot/+/75698/comment/13be8c45_cd32dd55 :
PS2, Line 17: 18
It looks like the part name is 18 characters, so should this be 19 for the terminating 0x00?

https://review.coreboot.org/c/coreboot/+/75698/comment/fac82743_15ece9aa :
PS2, Line 41: strncmp
strnicmp?  I don't know if we care.

https://review.coreboot.org/c/coreboot/+/75698/comment/e5a16206_2bebf9f5 :
PS2, Line 94: hynix_dram_cmos_check();
We can probably restrict this some more. I believe it's only relevant to frostflow, so that's an easy check, and the linker would exclude it from other mainboards.

We could also restrict when it runs based on the memory ID settings.  I'm not completely sure that's worthwhile though.

We can just make sure the cmos bits are clear on other boards/memory IDs.