Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29970 )
Change subject: qcs405: Add RPM support
......................................................................
Patch Set 32:
(2 comments)
https://review.coreboot.org/#/c/29970/29/src/soc/qualcomm/qcs405/include/soc...
File src/soc/qualcomm/qcs405/include/soc/memlayout.ld:
https://review.coreboot.org/#/c/29970/29/src/soc/qualcomm/qcs405/include/soc...
PS29, Line 35: 76K
This considerably reduces the size of the region compared to the previous patch set (from 0x2c000, w […]
Done
https://review.coreboot.org/#/c/29970/29/src/soc/qualcomm/qcs405/rpm_load_re...
File src/soc/qualcomm/qcs405/rpm_load_reset.c:
https://review.coreboot.org/#/c/29970/29/src/soc/qualcomm/qcs405/rpm_load_re...
PS29, Line 42: BIOS_DEBUG
BIOS_SPEW? (or remove completely)
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29970
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17f491f0a4bd0dce7522b7e80e1bac97ec18b945
Gerrit-Change-Number: 29970
Gerrit-PatchSet: 32
Gerrit-Owner: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sricharan Ramabadhran
srichara@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Fri, 28 Jun 2019 12:39:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment