Attention is currently required from: Ravi kumar, Taniya Das, Paul Menzel, mturney mturney, Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56588 )
Change subject: soc/qualcomm/common: clock: Add support for common clock driver
......................................................................
Patch Set 7:
(1 comment)
File src/soc/qualcomm/common/clock.c:
https://review.coreboot.org/c/coreboot/+/56588/comment/f3425ae2_33e53e28
PS2, Line 188: printk(BIOS_ERR, "ERROR: PLL did not lock!\n");
Yes the CPU would be on a default general purpose PLL which would be at a very low frequency.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56588
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03d1b4a2fb90303c7259ec08f312d78b4e33ec39
Gerrit-Change-Number: 56588
Gerrit-PatchSet: 7
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Taniya Das
tdas@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Taniya Das
tdas@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 03 Sep 2021 06:04:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Taniya Das
tdas@codeaurora.org
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment