HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34207 )
Change subject: nb/amd/amdmct/mct: Fix condition whith identical branches ......................................................................
nb/amd/amdmct/mct: Fix condition whith identical branches
Change-Id: Ie5ee2e2527c6745381c7bdd2cbe3212fdd28e8ba Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/amd/amdmct/mct/mctardk4.c 1 file changed, 1 insertion(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/34207/1
diff --git a/src/northbridge/amd/amdmct/mct/mctardk4.c b/src/northbridge/amd/amdmct/mct/mctardk4.c index 2e16a80..6c40d68 100644 --- a/src/northbridge/amd/amdmct/mct/mctardk4.c +++ b/src/northbridge/amd/amdmct/mct/mctardk4.c @@ -118,12 +118,8 @@ if (Speed == 3) { *AddrTmgCTL = 0x00202220; } else if (Speed == 2) { - if (MAAload == 4) + if (MAAload == 4 || MAAload == 16) *AddrTmgCTL = 0x002B2F00; - else if (MAAload == 16) - *AddrTmgCTL = 0x002B2F00; - else if (MAAload == 8) - *AddrTmgCTL = 0x002F2F00; else *AddrTmgCTL = 0x002F2F00; } else if (Speed == 1) {
HAOUAS Elyes has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/34207 )
Change subject: nb/amd/amdmct/mct: Fix condition whith identical branches ......................................................................
nb/amd/amdmct/mct: Fix condition whith identical branches
Spotted out using -Wduplicated-branches gcc warning option.
Change-Id: Ie5ee2e2527c6745381c7bdd2cbe3212fdd28e8ba Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/amd/amdmct/mct/mctardk4.c 1 file changed, 1 insertion(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/34207/2
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34207
to look at the new patch set (#3).
Change subject: nb/amd/amdmct/mct: Fix condition that has identical branches ......................................................................
nb/amd/amdmct/mct: Fix condition that has identical branches
Spotted out using -Wduplicated-branches gcc warning option.
Change-Id: Ie5ee2e2527c6745381c7bdd2cbe3212fdd28e8ba Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/amd/amdmct/mct/mctardk4.c 1 file changed, 1 insertion(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/34207/3
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34207 )
Change subject: nb/amd/amdmct/mct: Fix condition that has identical branches ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34207/1/src/northbridge/amd/amdmct/... File src/northbridge/amd/amdmct/mct/mctardk4.c:
https://review.coreboot.org/c/coreboot/+/34207/1/src/northbridge/amd/amdmct/... PS1, Line 121: if (MAAload == 4 || MAAload == 16) This might look nicer with switch statement. Or for documentation purposes otherwise show clearly which path MAAload == 8 takes.
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34207
to look at the new patch set (#4).
Change subject: nb/amd/amdmct/mct: Fix condition that has identical branches ......................................................................
nb/amd/amdmct/mct: Fix condition that has identical branches
Spotted out using -Wduplicated-branches gcc warning option.
Change-Id: Ie5ee2e2527c6745381c7bdd2cbe3212fdd28e8ba Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/amd/amdmct/mct/mctardk4.c 1 file changed, 8 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/34207/4
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34207 )
Change subject: nb/amd/amdmct/mct: Fix condition that has identical branches ......................................................................
Abandoned
see https://review.coreboot.org/c/coreboot/+/36962
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)