Attention is currently required from: Ashish Kumar Mishra, Bob Moragues, Karthik Ramasubramanian, Nick Vaccaro, Shelley Chen, Subrata Banik.
Ashish Kumar Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80564?usp=email )
Change subject: mb/google/brox: Handle bluetooth enable on devices
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80564/comment/346cfbda_14bf051d :
PS2, Line 9: On devices that don't have CNVi Bluetooth use BT_DISCRETE
can you please specify what this device is ? are you referring to a dedicate BT chip and not a combo […]
Yes, I meant discrete BT instead of CNVI. Will update the commit message to reflect that.
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/80564/comment/27d38539_0b13fd0c :
PS2, Line 24: field BT 10 10
: option BT_DISCRETE 0
: option BT_CNVI 1
: end
Sorry, I am not in the loop with the ISH work, but if we are using this bit for FW_CONFIG we should […]
I'm not aware where ISH assigned to 10. For now, we could reuse WIFI field. I'll rename the WIFI_CNVI to WIFI_BT_CNVI, etc. so that it's clear for BT usage as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80564?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iba008682fcfa7ddc1ec400649c8742c721666f1d
Gerrit-Change-Number: 80564
Gerrit-PatchSet: 2
Gerrit-Owner: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ashish Kumar Mishra
ashish.k.mishra@intel.corp-partner.google.com
Gerrit-CC: srinivas.kulkarni@intel.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 16 Feb 2024 05:25:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment