Attention is currently required from: Jérémy Compostella.
Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85146?usp=email )
Change subject: mb/google/fatcat: Limit Power Limit when battery is missing
......................................................................
Patch Set 14: -Code-Review
(1 comment)
File src/mainboard/google/fatcat/variants/baseboard/fatcat/ramstage.c:
https://review.coreboot.org/c/coreboot/+/85146/comment/a5773805_7b6d6c88?usp... :
PS14, Line 26: if (!google_chromeec_is_battery_present())
do we need `if (CONFIG(EC_GOOGLE_CHROMEEC)) {` check as well ?
```
if (CONFIG(EC_GOOGLE_CHROMEEC)) {
if (!google_chromeec_is_battery_present())
variant_update_cpu_power_limits(power_optimized_limits,
ARRAY_SIZE(power_optimized_limits))
}
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85146?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5d71e9edde0ecbd7aaf316cd754a6ebcff9da77e
Gerrit-Change-Number: 85146
Gerrit-PatchSet: 14
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Tue, 10 Dec 2024 12:56:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes