Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83923?usp=email )
Change subject: soc/mediatek/mt8196: Add NOR-Flash support ......................................................................
Patch Set 8:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83923/comment/0355eee9_04b0bb8d?usp... : PS5, Line 11: TEST=read nor flash data successfully.
How do you know, if the driver fully works then? (Anyway, feel free to ignore and mark as resolved. […]
Done
File src/soc/mediatek/mt8196/spi.c:
https://review.coreboot.org/c/coreboot/+/83923/comment/d2fb20d6_0094711a?usp... : PS5, Line 33: void mtk_snfc_init(void) : { : const struct pad_func *ptr; : : for (size_t i = 0; i < ARRAY_SIZE(nor_pinmux); i++) { : ptr = &nor_pinmux[i]; : : gpio_set_pull(ptr->gpio, GPIO_PULL_ENABLE, ptr->select); : gpio_set_mode(ptr->gpio, ptr->func); : : if (gpio_set_driving(ptr->gpio, GPIO_DRV_14_MA) < 0) : printk(BIOS_ERR, : "%s: failed to set pin drive to 14 mA for %d\n", : __func__, ptr->gpio.id); : else : printk(BIOS_DEBUG, "%s: got pin drive: %#x\n", __func__, : gpio_get_driving(ptr->gpio)); : } : }
I agree that part of the code (and the `pad_func` struct) can be moved to the common code (but of co […]
please review here CL:83989