yuchi.chen@intel.com has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/84109?usp=email )
Change subject: soc/intel/common/systemagent: read sa resources only from domain 0 ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84109/comment/94bc1c92_8cb83e1a?usp... : PS3, Line 8:
Why?
Some Intel SoC have multiple domains and each includes a systemagent, this patch is to avoid adding memory resources multiple times because they are identical to all domains. Although adding a memory resource multiple times works, it's a bit confusing.
File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/c/coreboot/+/84109/comment/c1f022df_bae89234?usp... : PS3, Line 277: reading
read
I will update it in another patch.