Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Morgan Jang, Patrick Rudolph, Tim Chu.
Shuo Liu has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85557?usp=email )
Change subject: soc/intel/xeon_sp: Merge SKX and CPX
......................................................................
Patch Set 5:
(5 comments)
Patchset:
PS5:
May
Commit Message:
https://review.coreboot.org/c/coreboot/+/85557/comment/2aad8f8b_fe1700f7?usp... :
PS5, Line 10: - Create a new 14nm folder
There are '(xx)nm - old' and 'intel(x) - new' for process namings which is confusing. Maybe still using gen(x) as what is currently using to be consistent?
File src/soc/intel/xeon_sp/14nm/acpi/gpio.asl:
PS5:
Should we still place the 'acpi' ahead of '14nm (or gen1)' to be consistent?
File src/soc/intel/xeon_sp/cpx/Kconfig:
https://review.coreboot.org/c/coreboot/+/85557/comment/a176eb9a_83fb016b?usp... :
PS5, Line 5: select SOC_INTEL_XEON_SP_14NM
Maybe we can have a SOC_INTEL_XEON_SP_GEN3 but select the same kconfigs as SOC_INTEL_XEON_SP_GEN1
File src/soc/intel/xeon_sp/skx/Kconfig:
https://review.coreboot.org/c/coreboot/+/85557/comment/0f65b4f1_87a8708a?usp... :
PS5, Line 5: select SOC_INTEL_XEON_SP_14NM
SOC_INTEL_XEON_SP_GEN1?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85557?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I915d502efc36b299e089158c60e81822dfa2b333
Gerrit-Change-Number: 85557
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 13 Dec 2024 02:02:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No