Attention is currently required from: Jakub Czapiga, Jędrzej Ciupis, Matt DeVillier.
Paul Menzel has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84359?usp=email )
Change subject: mb/google/dedede: Select INTEL_CRASHLOG only for ChromeOS builds
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84359/comment/adbc5334_3a6638d4?usp... :
PS1, Line 9: significantly impacts
: boot time negatively
I'm not sitting here with a stopwatch, but it's an order of magnitude (ie, 10s vs 1s)
Thank you. That is good enough for me.
https://review.coreboot.org/c/coreboot/+/84359/comment/d75d70c5_04ebd3df?usp... :
PS1, Line 10: breaks USB detection in edk2 payload
the device was effectively unusable as it didn't have an OS installed on internal storage
Understood.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84359?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I53be4befe9a04bdaece21f40f93af6599baa7e0b
Gerrit-Change-Number: 84359
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jędrzej Ciupis
jciupis@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jędrzej Ciupis
jciupis@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Sun, 15 Sep 2024 06:22:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org