Change in coreboot[master]: drivers/tpm/cr50: Use cr50_get_firmware_version in get_board_cfg
Attention is currently required from: Julius Werner, Nick Vaccaro. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62964 )
Change subject: drivers/tpm/cr50: Use cr50_get_firmware_version in get_board_cfg ......................................................................
Patch Set 4:
(2 comments)
File src/drivers/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/62964/comment/12fd8a95_7517b058 PS3, Line 16: static struct cr50_firmware_version cr50_firmware_version;
Maybe just make this a static local in cr50_get_firmware_version() so it can't be used uninitialized […]
That will help fix it yeah.
https://review.coreboot.org/c/coreboot/+/62964/comment/49e6db2f_d204bab9 PS3, Line 104: if (!cr50_fw_supports_board_cfg(&cr50_firmware_version))
Does this have the same issue?
It currently does not, because of the implicit flow of calls into the cr50 driver, but I will change it for symmetry's sake (always use the same method to get FW version)
-
Tim Wawrzynczak (Code Review)