Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36172 )
Change subject: sb/intel/common/smihandler: Fix compilation on x86_64 ......................................................................
sb/intel/common/smihandler: Fix compilation on x86_64
Use uintptr_t instead of uint32_t to fix compilation on x86_64.
Change-Id: I5584f849202c0a833c751a80bdd9a8f86c60169a Signed-off-by: Patrick Rudolph siro@das-labor.org --- M src/southbridge/intel/common/smihandler.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/36172/1
diff --git a/src/southbridge/intel/common/smihandler.c b/src/southbridge/intel/common/smihandler.c index d61238c..5582051 100644 --- a/src/southbridge/intel/common/smihandler.c +++ b/src/southbridge/intel/common/smihandler.c @@ -274,7 +274,7 @@ u8 sub_command, ret; em64t101_smm_state_save_area_t *io_smi = smi_apmc_find_state_save(APM_CNT_SMMSTORE); - uint32_t reg_ebx; + uintptr_t reg_rbx;
if (!io_smi) return; @@ -282,10 +282,10 @@ sub_command = (io_smi->rax >> 8) & 0xff;
/* Parameter buffer in EBX */ - reg_ebx = io_smi->rbx; + reg_rbx = (uintptr_t)io_smi->rbx;
/* drivers/smmstore/smi.c */ - ret = smmstore_exec(sub_command, (uintptr_t *)reg_ebx); + ret = smmstore_exec(sub_command, (void *)reg_rbx); io_smi->rax = ret; }
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36172 )
Change subject: sb/intel/common/smihandler: Fix compilation on x86_64 ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36172 )
Change subject: sb/intel/common/smihandler: Fix compilation on x86_64 ......................................................................
sb/intel/common/smihandler: Fix compilation on x86_64
Use uintptr_t instead of uint32_t to fix compilation on x86_64.
Change-Id: I5584f849202c0a833c751a80bdd9a8f86c60169a Signed-off-by: Patrick Rudolph siro@das-labor.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/36172 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/southbridge/intel/common/smihandler.c 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/southbridge/intel/common/smihandler.c b/src/southbridge/intel/common/smihandler.c index d61238c..5582051 100644 --- a/src/southbridge/intel/common/smihandler.c +++ b/src/southbridge/intel/common/smihandler.c @@ -274,7 +274,7 @@ u8 sub_command, ret; em64t101_smm_state_save_area_t *io_smi = smi_apmc_find_state_save(APM_CNT_SMMSTORE); - uint32_t reg_ebx; + uintptr_t reg_rbx;
if (!io_smi) return; @@ -282,10 +282,10 @@ sub_command = (io_smi->rax >> 8) & 0xff;
/* Parameter buffer in EBX */ - reg_ebx = io_smi->rbx; + reg_rbx = (uintptr_t)io_smi->rbx;
/* drivers/smmstore/smi.c */ - ret = smmstore_exec(sub_command, (uintptr_t *)reg_ebx); + ret = smmstore_exec(sub_command, (void *)reg_rbx); io_smi->rax = ret; }
-
Arthur Heymans (Code Review) -
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)