Attention is currently required from: Eric Herrmann, Karthik Ramasubramanian, Shelley Chen, Sowmya Aralguppe.
Ashish Kumar Mishra has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83406?usp=email )
Change subject: mb/google/brox: Reduce PL values for booting without battery
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83406/comment/88420bb3_0628e94d?usp... :
PS2, Line 9: Reduce PsysPL2 and PL4 values to boot without battery and prevent
Please include "PsysPL3" changes in commit message body.
https://review.coreboot.org/c/coreboot/+/83406/comment/d5a3e7ec_5a019e9f?usp... :
PS2, Line 14: TEST=flash
Please format into a single line and be bit more descriptive in the TEST definition. Suggest: "cold reboot" = "cold boot" and "proto2 SKU1" = "Brox Proto2 SKU1"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83406?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia0074bfc97c54f07d0b7257393de7c355e36b262
Gerrit-Change-Number: 83406
Gerrit-PatchSet: 2
Gerrit-Owner: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Reviewer: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Reviewer: Eric Herrmann
eherrmann@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Attention: Eric Herrmann
eherrmann@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 11 Jul 2024 06:10:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes