Attention is currently required from: Raul Rangel, Martin Roth, Karthik Ramasubramanian.
Robert Zieba has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69914 )
Change subject: device/xhci: Add functions to work with resource pointers ......................................................................
Patch Set 13:
(3 comments)
File src/device/xhci_resource.c:
https://review.coreboot.org/c/coreboot/+/69914/comment/04689673_9c8229d3 PS11, Line 17:
Anything that should be accessed cautiously in SMM - eg. input parameters. […]
When these functions are used in SMM for XHCI wake-event logging they take in the resources that were stored in SMRAM so there shouldn't be any issues.
https://review.coreboot.org/c/coreboot/+/69914/comment/8d60a9ca_10f56632 PS11, Line 18: enum cb_err xhci_resource_for_each_ext_cap(const struct resource *res, void *context,
that open brace { should be on the previous line […]
This seems to be a false positive. Since this is a function definition the brace should be on the next line. Uploading a CL with the brace on the same line results in a warning that it should be on the next line.
https://review.coreboot.org/c/coreboot/+/69914/comment/f9eaf3cf_8110a603 PS11, Line 95: enum cb_err xhci_resource_for_each_supported_usb_cap(
that open brace { should be on the previous line […]
Same as other warning.