Attention is currently required from: Felix Held, Nico Huber.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80465?usp=email )
Change subject: [UNTESTED]nb/intel/gm45: Use ssdt PCI root bridge generator ......................................................................
Patch Set 3:
(1 comment)
File src/northbridge/intel/gm45/northbridge.c:
https://review.coreboot.org/c/coreboot/+/80465/comment/274dbc55_48cdd84a : PS3, Line 111: struct resource *upper_pci = find_resource(dev, IOINDEX_SUBTRACTIVE(2, 0)); : if (upper_pci) : upper_pci->base = touud; : : struct resource *lower_pci = find_resource(dev, IOINDEX_SUBTRACTIVE(1, 0)); : if (lower_pci) : lower_pci->base = tolud;
i'd also prefer to just report the correct resources. unrelated to this patch, but the IOINDEX_SUBTRACTIVE macros should probably also have the link argument dropped
Or drop the macro altogether. It's only used to declare resources but never to find them later.