Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45694 )
Change subject: soc/intel/*/chip.h: Use `uint32_t` for `tcc_offset` ......................................................................
soc/intel/*/chip.h: Use `uint32_t` for `tcc_offset`
Newer platforms use an unsigned type instead of an int. Follow suit.
Change-Id: I316864d3aed203c7c2bc962772895774fbc0c8da Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/apollolake/chip.h M src/soc/intel/broadwell/chip.h M src/soc/intel/skylake/chip.h 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/45694/1
diff --git a/src/soc/intel/apollolake/chip.h b/src/soc/intel/apollolake/chip.h index 521d3ee..6e4c82d 100644 --- a/src/soc/intel/apollolake/chip.h +++ b/src/soc/intel/apollolake/chip.h @@ -124,7 +124,7 @@ int dptf_enable;
/* TCC activation offset value in degrees Celsius */ - int tcc_offset; + uint32_t tcc_offset;
/* Configure Audio clk gate and power gate * IOSF-SB port ID 92 offset 0x530 [5] and [3] diff --git a/src/soc/intel/broadwell/chip.h b/src/soc/intel/broadwell/chip.h index f559410..ae43353 100644 --- a/src/soc/intel/broadwell/chip.h +++ b/src/soc/intel/broadwell/chip.h @@ -138,7 +138,7 @@ int deep_sx_enable_dc;
/* TCC activation offset */ - int tcc_offset; + uint32_t tcc_offset; };
typedef struct soc_intel_broadwell_config config_t; diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h index a623292..fa30c1d 100644 --- a/src/soc/intel/skylake/chip.h +++ b/src/soc/intel/skylake/chip.h @@ -85,7 +85,7 @@ uint32_t deep_sx_config;
/* TCC activation offset */ - int tcc_offset; + uint32_t tcc_offset;
/* Package PL4 power limit in Watts */ u32 PowerLimit4;
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45694 )
Change subject: soc/intel/*/chip.h: Use `uint32_t` for `tcc_offset` ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45694 )
Change subject: soc/intel/*/chip.h: Use `uint32_t` for `tcc_offset` ......................................................................
soc/intel/*/chip.h: Use `uint32_t` for `tcc_offset`
Newer platforms use an unsigned type instead of an int. Follow suit.
Change-Id: I316864d3aed203c7c2bc962772895774fbc0c8da Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45694 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/apollolake/chip.h M src/soc/intel/broadwell/chip.h M src/soc/intel/skylake/chip.h 3 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved
diff --git a/src/soc/intel/apollolake/chip.h b/src/soc/intel/apollolake/chip.h index 521d3ee..6e4c82d 100644 --- a/src/soc/intel/apollolake/chip.h +++ b/src/soc/intel/apollolake/chip.h @@ -124,7 +124,7 @@ int dptf_enable;
/* TCC activation offset value in degrees Celsius */ - int tcc_offset; + uint32_t tcc_offset;
/* Configure Audio clk gate and power gate * IOSF-SB port ID 92 offset 0x530 [5] and [3] diff --git a/src/soc/intel/broadwell/chip.h b/src/soc/intel/broadwell/chip.h index f559410..ae43353 100644 --- a/src/soc/intel/broadwell/chip.h +++ b/src/soc/intel/broadwell/chip.h @@ -138,7 +138,7 @@ int deep_sx_enable_dc;
/* TCC activation offset */ - int tcc_offset; + uint32_t tcc_offset; };
typedef struct soc_intel_broadwell_config config_t; diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h index a623292..fa30c1d 100644 --- a/src/soc/intel/skylake/chip.h +++ b/src/soc/intel/skylake/chip.h @@ -85,7 +85,7 @@ uint32_t deep_sx_config;
/* TCC activation offset */ - int tcc_offset; + uint32_t tcc_offset;
/* Package PL4 power limit in Watts */ u32 PowerLimit4;
-
Angel Pons (Code Review) -
Subrata Banik (Code Review)