Attention is currently required from: Malik Hsu, Nick Vaccaro.
Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60071 )
Change subject: mb/google/brya/var/primus{4es}: Configure Acoustic noise mitigation
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60071/comment/0cde4421_b3430aaa
PS1, Line 7: primus
Sometimes we use shell-like glob sequences to indicate we are modifying more than one board, in this […]
Done
https://review.coreboot.org/c/coreboot/+/60071/comment/4e1989bc_ab863b8b
PS1, Line 8:
Maybe mention that this was verified to meet the audible noise specification (or is still in testing […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60071
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e0baf78a841278efda912cc5e4e9970329aacf6
Gerrit-Change-Number: 60071
Gerrit-PatchSet: 2
Gerrit-Owner: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Reviewer: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Tue, 14 Dec 2021 09:25:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment