Attention is currently required from: Kenneth Chan, Nick Vaccaro, Paul Menzel.
Ren Kuo has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84143?usp=email )
Change subject: mb/google/brox/jubilant: Tune I2C timing ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84143/comment/5c99d44c_d43e79db?usp... : PS1, Line 7: I2C signal tuning
Please look through `git log --oneline` on how to write the summary (also for I2C tuning).
fixed.
https://review.coreboot.org/c/coreboot/+/84143/comment/8822f7c8_5b50694b?usp... : PS1, Line 10: HW requirement
… of ….
fixed.
https://review.coreboot.org/c/coreboot/+/84143/comment/f6b2f9ee_ce0c3f03?usp... : PS1, Line 10: 250ns
The diff does more than this?
The all I2c port timing is in one struct and default setting in brox baseboard. We need to copy the struct
https://review.coreboot.org/c/coreboot/+/84143/comment/ab9ddacb_78f8cd5b?usp... : PS1, Line 14: Measure the i2c signal on jubilant to meet spec
Please include your measurements.
fixed.
-
Ren Kuo (Code Review)