Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68685 )
Change subject: drivers/ipmi/ipmi_kcs_ops.c: accommodate BMC revision being 0 ......................................................................
drivers/ipmi/ipmi_kcs_ops.c: accommodate BMC revision being 0
BMC major/minor revision may be 0. Get the value directly from BMC without checking to accommodate such situation.
Signed-off-by: Tim Chu Tim.Chu@quantatw.com Signed-off-by: Jonathan Zhang jonzhang@meta.com Change-Id: I0e08c6d02de8f6efceb69b6d6cebad9d61cfd20e Reviewed-on: https://review.coreboot.org/c/coreboot/+/68685 Reviewed-by: Shuming Chu (Shuming) s1218944@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martin.roth@amd.corp-partner.google.com --- M src/drivers/ipmi/ipmi_kcs_ops.c 1 file changed, 21 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Shuming Chu (Shuming): Looks good to me, but someone else must approve Martin Roth: Looks good to me, approved
diff --git a/src/drivers/ipmi/ipmi_kcs_ops.c b/src/drivers/ipmi/ipmi_kcs_ops.c index a2ad7ab..28ced49 100644 --- a/src/drivers/ipmi/ipmi_kcs_ops.c +++ b/src/drivers/ipmi/ipmi_kcs_ops.c @@ -259,14 +259,8 @@
void ipmi_bmc_version(uint8_t *ipmi_bmc_major_revision, uint8_t *ipmi_bmc_minor_revision) { - if (!bmc_revision_major || !bmc_revision_minor) { - printk(BIOS_ERR, "IPMI: BMC revision missing\n"); - *ipmi_bmc_major_revision = 0; - *ipmi_bmc_minor_revision = 0; - } else { - *ipmi_bmc_major_revision = bmc_revision_major; - *ipmi_bmc_minor_revision = bmc_revision_minor; - } + *ipmi_bmc_major_revision = bmc_revision_major; + *ipmi_bmc_minor_revision = bmc_revision_minor; }
#if CONFIG(GENERATE_SMBIOS_TABLES)