Attention is currently required from: Tarun Tuli, Kangheui Won, Kapil Porwal, Ivy Jian, Eric Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74530 )
Change subject: lib: Perform early initialization of FW config in ramstage
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Maybe add stage check like this CL? https://review.coreboot.org/c/coreboot/+/54752
i agree with your with the purpose/meaning of BS_PRE_DEVICE but if you think we shouldn't move fw_config_init earlier than INIT_CHIPS then I need to use pci_read16 to kw the DID rather relying on the devicetree entries.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74530
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If36e7c7d2edc74a2b7fcc192690af73651e87183
Gerrit-Change-Number: 74530
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 19 Apr 2023 08:16:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kangheui Won
khwon@chromium.org
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment