Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40570 )
Change subject: soc/intel/jasperlake: Add function to display ME firmware status info ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40570/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40570/2//COMMIT_MSG@12 PS2, Line 12:
Understood.
Ack
https://review.coreboot.org/c/coreboot/+/40570/2/src/soc/intel/jasperlake/in... File src/soc/intel/jasperlake/include/soc/me.h:
https://review.coreboot.org/c/coreboot/+/40570/2/src/soc/intel/jasperlake/in... PS2, Line 12: u32 mfg_mode: 1;
Please mention the renaming though in the commit message.
Done