Attention is currently required from: Shelley Chen, Felix Singer, Nico Huber, Furquan Shaikh, Martin Roth, Tim Wawrzynczak, Paul Menzel, Julius Werner, Kyösti Mälkki, Yu-Ping Wu, Jianjun Wang.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57861 )
Change subject: Documentation/RFC: Generalize PCI support in coreboot
......................................................................
Patch Set 12:
(2 comments)
File Documentation/RFC/pci_config_access.md:
https://review.coreboot.org/c/coreboot/+/57861/comment/ec0ce5b8_e949faaf
PS12, Line 129: MMONCF
typo: MMCONF
https://review.coreboot.org/c/coreboot/+/57861/comment/89598e77_f3b387ee
PS12, Line 125: ### Specifying MMIO support for PCI devices that don't support ECAM
:
: We’ll need to be able to distinguish between a platform using the ECAM access
: method and any other MMIO access mechanism. For devices that support ECAM, they
: would have to select the `ECAM_MMONCF_SUPPORT` config. For devices that don't
: support ECAM and would still need MMIO support, they would need to explictly
: select the `NO_ECAM_MMCONF_SUPPORT` config and include the `pci_mmio_cfg.h'
: header file in their platform-specific source.
The "example" linked below around get_pci_mmio_cfgbase() looks […]
+1 to what Nico said.
To me, the `NO_ECAM_MMCONF_SUPPORT` option is about the coreboot code, not the hardware. Only implementing method 1 with `pci_map_bus()` and selecting `NO_ECAM_MMCONF_SUPPORT` is completely fine, even if the hardware supports MMCONF.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57861
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a56d932f6e047087c38a7687564065cc1562363
Gerrit-Change-Number: 57861
Gerrit-PatchSet: 12
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Fri, 19 Nov 2021 13:18:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-MessageType: comment