Attention is currently required from: Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Patrick Rudolph, Karthik Ramasubramanian. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57096 )
Change subject: drivers/intel/dptf: Introduce new thermal control mechanism for pch device ......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57096/comment/3e971d52_7c8c5d39 PS1, Line 7: tpch: Introduce new thermal control mechanism for pch device
drivers/intel/tpch:
Done
https://review.coreboot.org/c/coreboot/+/57096/comment/726419fd_505a5ce1 PS1, Line 9: Introduce new thermal control mechanism for pch device.
Please elaborate.
Done
File src/drivers/intel/tpch/tpch.c:
https://review.coreboot.org/c/coreboot/+/57096/comment/9ca14f21_e4dfc50e PS1, Line 14: static void tpch_write_hid(bool is_eisa, const char *hid) : { : if (is_eisa) : acpigen_emit_eisaid(hid); : else : acpigen_write_string(hid); : }
if this driver ends up merging with the regular DPTF drive, this function is moot, there is `dptf_wr […]
Done
https://review.coreboot.org/c/coreboot/+/57096/comment/850b3c69_5b6611d8 PS1, Line 55: acpigen_write_scope("\_SB"); : acpigen_write_device(acpi_device_name(dev));
if TPCH is added to the DPTF participants, then you can add support in `scope_of` to handle this.
Ack