Attention is currently required from: Christian Walter, Maciej Pijanowski.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73972?usp=email )
Change subject: intelmetool: Add PCI ID for TGL-U, ADL-P, ADL-S ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73972/comment/4f397348_75b30064 : PS1, Line 7: TGL,ADL
The patch does not add an exhaustive list of PCI IDs for TGL and ADL. […]
Done
File util/intelmetool/intelmetool.h:
https://review.coreboot.org/c/coreboot/+/73972/comment/c1f6ad3a_0edacfed : PS1, Line 441: #define PCI_DEVICE_ID_INTEL_TIGERLAKE 0xA0E0 /* Tiger Lake */ : #define PCI_DEVICE_ID_INTEL_ALDERLAKE_P 0x51E0 /* Alder Lake P */ : #define PCI_DEVICE_ID_INTEL_ALDERLAKE_S 0x7AE8 /* Alder Lake S */
I think that was fixed, would you like to take a look again?
Now when I look at it, those extra IDs are for HECI2/3/4 devices, which typically are not available. My bad. All we need is the include the IDs ending with *_CSE0
-
Michał Żygowski (Code Review)