Attention is currently required from: Máté Kukri.
Felix Singer has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/82053?usp=email )
Change subject: [WIP] OptiPlex 3050 port ......................................................................
Patch Set 9:
(3 comments)
File src/mainboard/dell/optiplex_3050/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/82053/comment/3806fd0e_d0dd39b9?usp... : PS9, Line 41: # Host bridge : Equals to chipset devicetree, remove
https://review.coreboot.org/c/coreboot/+/82053/comment/7f85efd8_1cd0a0a0?usp... : PS9, Line 44: # Intel iGPU These comments just repeat the device name, no? Seems superfluous to me.
https://review.coreboot.org/c/coreboot/+/82053/comment/b157990f_38f591a6?usp... : PS9, Line 87: register "SataPortsEnable" = "{ : [0] = 1, : }" ```suggestion register "SataPortsEnable[0]" = "1" ```