Attention is currently required from: Kevin Chang, Tim Wawrzynczak, Zhuohao Lee.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50874 )
Change subject: mb/google/volteer/variant/lindar: Modify PL2 value.
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50874/comment/9d4dc1b5_6ffe6f2c
PS1, Line 7: mb/google/volteer/variant/lindar: Modify PL2 value.
Please remove the dot/period at the end of the git commit message summary.
https://review.coreboot.org/c/coreboot/+/50874/comment/263d8fa7_ee2406d7
PS1, Line 9: Modify PL2 to 25W from 60W.
Maybe use
Decrease PL2 from 60 W to 25 W
and use it as git commit message summary.
In the body, please documented, where you got the value from.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50874
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I848a8af1b86165c0bdd10804b470416c1cad9710
Gerrit-Change-Number: 50874
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Lauren Ting
lauren.ting@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Comment-Date: Thu, 18 Feb 2021 10:20:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment