Change in coreboot[master]: soc/intel/../thermal: Drop unused `dev` parameter in pch_get_ltt_value() - coreboot-gerrit

19 Nov 2021


      Attention is currently required from:  Felix Singer, Maulik V Vaghela, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59390 )
Change subject: soc/intel/../thermal: Drop unused `dev` parameter in pch_get_ltt_value()
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59390/comment/00dbbc56_d06e9449 
PS3, Line 7: /../
...
soc/intel/common/block/thermal: […]
Maybe `soc/intel/cmn/thermal`, but I'm not sure if it's an improvement.
Felix, any suggestions? Or can we leave this as-is?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59390
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecdf6f6c3023f896a27e212d7c59b2030a3fd116
Gerrit-Change-Number: 59390
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC:  Felix Singer felixsinger@posteo.net
Gerrit-Attention:  Felix Singer felixsinger@posteo.net
Gerrit-Attention: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Fri, 19 Nov 2021 13:21:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To:  Felix Singer felixsinger@posteo.net
Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com
Gerrit-MessageType: comment