[M] Change in coreboot[main]: soc/amd/*/root_complex: introduce and use domain_iohc_info struct

[Martin Roth (Code Review)]

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Varshit Pandya.

Martin Roth has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/83443?usp=email )

Change subject: soc/amd/*/root_complex: introduce and use domain_iohc_info struct
......................................................................

Patch Set 1: Code-Review+2

(2 comments)

File src/soc/amd/common/block/root_complex/root_complex.c:

https://review.coreboot.org/c/coreboot/+/83443/comment/e749de75_a76b4d9c?usp... :
PS1, Line 15: domain->path.domain.domain
Nit: This domaindomaindomain is kind of ugly. Can any of the domains be anything different to differentiate them? Doesn't need to be updated in this patch.

domain_number, domain_id, domain_struct, pci_domain, kingdom, etc.

https://review.coreboot.org/c/coreboot/+/83443/comment/b80cd6f6_b142adcb?usp... :
PS1, Line 34: signed int
The fabric ID is a uint32_t, so why use a signed int for the return type? Looking at the ID values, can we make the ID a signed int or uint16_t so that the ID value fits in the positive values of a signed int?

Probably not a big deal, I know, and I see that it's just moved from the other file, but maybe consider changing it at some point?