Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76018?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for Device4Enable dt option ......................................................................
mb/{cfl,cml,whl}: Use true/false macros for Device4Enable dt option
The true/false macros give the reader a better understanding about how the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \ option="Device4Enable" && \ grep -r "${dt_line}" src/mainboard | \ cut -d ':' -f 1 | \ xargs sed -i'' -e "s/"${option}".*=.*"1"/${option} = true/g" -e "s/"${option}".*=.*"0"/${option} = false/g"
Change-Id: I16b77d6f8dc1a8a5d03ca86961069c8560c2c479 Signed-off-by: lilacious yuchenhe126@gmail.com --- M src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb M src/mainboard/google/drallion/variants/drallion/devicetree.cb M src/mainboard/google/hatch/variants/baseboard/devicetree.cb M src/mainboard/google/puff/variants/baseboard/devicetree.cb M src/mainboard/google/sarien/variants/arcada/devicetree.cb M src/mainboard/google/sarien/variants/sarien/devicetree.cb M src/mainboard/purism/librem_cnl/devicetree.cb M src/mainboard/starlabs/starbook/variants/cml/devicetree.cb M src/mainboard/system76/addw1/devicetree.cb M src/mainboard/system76/cml-u/devicetree.cb M src/mainboard/system76/gaze15/devicetree.cb M src/mainboard/system76/oryp5/devicetree.cb M src/mainboard/system76/oryp6/devicetree.cb M src/mainboard/system76/whl-u/devicetree.cb 14 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/76018/1
diff --git a/src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb b/src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb index e55cfd1..6e11a5a 100644 --- a/src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb +++ b/src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb @@ -72,7 +72,7 @@ }" end device pci 04.0 on # SA Thermal device - register "Device4Enable" = "1" + register Device4Enable = true end device pci 12.0 on end # Thermal Subsystem device pci 12.5 off end # UFS SCS diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index a505f6a..208a3ef 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -46,7 +46,7 @@ .tdp_pl2_override = 51, .psys_pmax = 140, }" - register "Device4Enable" = "1" + register Device4Enable = true register "AcousticNoiseMitigation" = "1" register "SlowSlewRateForIa" = "2" register "SlowSlewRateForGt" = "2" diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index fe3ad66..2cf7598 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -35,7 +35,7 @@ .tdp_pl1_override = 15, .tdp_pl2_override = 64, }" - register "Device4Enable" = "1" + register Device4Enable = true # Enable eDP device register "DdiPortEdp" = "1" # Enable HPD for DDI ports B/C diff --git a/src/mainboard/google/puff/variants/baseboard/devicetree.cb b/src/mainboard/google/puff/variants/baseboard/devicetree.cb index 6b65f34..ae2d6a4 100644 --- a/src/mainboard/google/puff/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/puff/variants/baseboard/devicetree.cb @@ -35,7 +35,7 @@ .tdp_pl1_override = 15, .tdp_pl2_override = 64, }" - register "Device4Enable" = "1" + register Device4Enable = true # Enable eDP device register "DdiPortEdp" = "1" # Enable HPD for DDI ports B/C diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index 93e6b6f..e49e7f7 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -35,7 +35,7 @@ .tdp_pl2_override = 51, .psys_pmax = 140, }" - register "Device4Enable" = "1" + register Device4Enable = true register "AcousticNoiseMitigation" = "1" register "SlowSlewRateForIa" = "2" register "SlowSlewRateForGt" = "2" diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb index a7769d9..3e40a46 100644 --- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb +++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb @@ -43,7 +43,7 @@ .tdp_pl2_override = 51, .psys_pmax = 136, }" - register "Device4Enable" = "1" + register Device4Enable = true # Enable eDP device register "DdiPortEdp" = "1" # Enable HPD for DDI ports B/C diff --git a/src/mainboard/purism/librem_cnl/devicetree.cb b/src/mainboard/purism/librem_cnl/devicetree.cb index 54b5722..944f069 100644 --- a/src/mainboard/purism/librem_cnl/devicetree.cb +++ b/src/mainboard/purism/librem_cnl/devicetree.cb @@ -47,7 +47,7 @@ device pci 00.0 on end # Host Bridge device pci 02.0 on end # Integrated Graphics Device device pci 04.0 on # SA Thermal device - register "Device4Enable" = "1" + register Device4Enable = true end device pci 12.0 on end # Thermal Subsystem device pci 13.0 off end # Integrated Sensor Hub diff --git a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb index 2b790599..ef544cd 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb @@ -56,7 +56,7 @@ device pci 00.0 on end # Host Bridge device pci 02.0 on end # Integrated Graphics Device device pci 04.0 on # SA Thermal Device - register "Device4Enable" = "1" + register Device4Enable = true end device pci 12.0 off end # Thermal Subsystem device pci 12.5 off end # UFS SCS diff --git a/src/mainboard/system76/addw1/devicetree.cb b/src/mainboard/system76/addw1/devicetree.cb index 1b3aa7b..8bd9d60 100644 --- a/src/mainboard/system76/addw1/devicetree.cb +++ b/src/mainboard/system76/addw1/devicetree.cb @@ -59,7 +59,7 @@ end device pci 02.0 on end # Integrated Graphics Device device pci 04.0 on # SA Thermal device - register "Device4Enable" = "1" + register Device4Enable = true end device pci 12.0 on end # Thermal Subsystem device pci 12.5 off end # UFS SCS diff --git a/src/mainboard/system76/cml-u/devicetree.cb b/src/mainboard/system76/cml-u/devicetree.cb index 2b18e9a..a35dfea 100644 --- a/src/mainboard/system76/cml-u/devicetree.cb +++ b/src/mainboard/system76/cml-u/devicetree.cb @@ -62,7 +62,7 @@ register "gfx" = "GMA_DEFAULT_PANEL(0)" end device pci 04.0 on # SA Thermal device - register "Device4Enable" = "1" + register Device4Enable = true end device pci 12.0 on end # Thermal Subsystem device pci 12.5 off end # UFS SCS diff --git a/src/mainboard/system76/gaze15/devicetree.cb b/src/mainboard/system76/gaze15/devicetree.cb index ffdcb4c..f46b289 100644 --- a/src/mainboard/system76/gaze15/devicetree.cb +++ b/src/mainboard/system76/gaze15/devicetree.cb @@ -60,7 +60,7 @@ register "gfx" = "GMA_DEFAULT_PANEL(0)" end device pci 04.0 on # SA Thermal device - register "Device4Enable" = "1" + register Device4Enable = true end device pci 12.0 on end # Thermal Subsystem device pci 12.5 off end # UFS SCS diff --git a/src/mainboard/system76/oryp5/devicetree.cb b/src/mainboard/system76/oryp5/devicetree.cb index 4db7318..c794d06 100644 --- a/src/mainboard/system76/oryp5/devicetree.cb +++ b/src/mainboard/system76/oryp5/devicetree.cb @@ -68,7 +68,7 @@ register "gfx" = "GMA_DEFAULT_PANEL(0)" end device pci 04.0 on # SA Thermal device - register "Device4Enable" = "1" + register Device4Enable = true end device pci 12.0 on end # Thermal Subsystem device pci 12.5 off end # UFS SCS diff --git a/src/mainboard/system76/oryp6/devicetree.cb b/src/mainboard/system76/oryp6/devicetree.cb index f1113c7..a2d56d7 100644 --- a/src/mainboard/system76/oryp6/devicetree.cb +++ b/src/mainboard/system76/oryp6/devicetree.cb @@ -65,7 +65,7 @@ register "gfx" = "GMA_DEFAULT_PANEL(0)" end device pci 04.0 on # SA Thermal device - register "Device4Enable" = "1" + register Device4Enable = true end device pci 12.0 on end # Thermal Subsystem device pci 12.5 off end # UFS SCS diff --git a/src/mainboard/system76/whl-u/devicetree.cb b/src/mainboard/system76/whl-u/devicetree.cb index 82d525f..ce0f376 100644 --- a/src/mainboard/system76/whl-u/devicetree.cb +++ b/src/mainboard/system76/whl-u/devicetree.cb @@ -62,7 +62,7 @@ register "gfx" = "GMA_STATIC_DISPLAYS(0)" end device pci 04.0 on # SA Thermal device - register "Device4Enable" = "1" + register Device4Enable = true end device pci 12.0 on end # Thermal Subsystem device pci 12.5 off end # UFS SCS