Edward Hill has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31893
Change subject: mb/google/kahlee/aleena: Add EC_ENABLE_TBMC_DEVICE ......................................................................
mb/google/kahlee/aleena: Add EC_ENABLE_TBMC_DEVICE
Enable ACPI TBMC notification on tablet mode change to support convertible Aleena devices.
BUG=b:124132058 BRANCH=grunt TEST=evtest shows tablet mode events
Change-Id: Iaf8ef031d4660f0791b5f664880437e6dfa58dc8 Signed-off-by: Edward Hill ecgh@chromium.org --- M src/mainboard/google/kahlee/variants/aleena/include/variant/ec.h 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/31893/1
diff --git a/src/mainboard/google/kahlee/variants/aleena/include/variant/ec.h b/src/mainboard/google/kahlee/variants/aleena/include/variant/ec.h index 12c6de6..0aa2e21 100644 --- a/src/mainboard/google/kahlee/variants/aleena/include/variant/ec.h +++ b/src/mainboard/google/kahlee/variants/aleena/include/variant/ec.h @@ -16,6 +16,9 @@ /* Enable EC backed Keyboard Backlight in ACPI */ #define EC_ENABLE_KEYBOARD_BACKLIGHT
+/* Enable Tablet switch */ +#define EC_ENABLE_TBMC_DEVICE + /* * Enable EC sync interrupt via GPIO controller, EC_SYNC_IRQ is defined in * variant/gpio.h
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31893 )
Change subject: mb/google/kahlee/aleena: Add EC_ENABLE_TBMC_DEVICE ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31893 )
Change subject: mb/google/kahlee/aleena: Add EC_ENABLE_TBMC_DEVICE ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31893 )
Change subject: mb/google/kahlee/aleena: Add EC_ENABLE_TBMC_DEVICE ......................................................................
mb/google/kahlee/aleena: Add EC_ENABLE_TBMC_DEVICE
Enable ACPI TBMC notification on tablet mode change to support convertible Aleena devices.
BUG=b:124132058 BRANCH=grunt TEST=evtest shows tablet mode events
Change-Id: Iaf8ef031d4660f0791b5f664880437e6dfa58dc8 Signed-off-by: Edward Hill ecgh@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/31893 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Martin Roth martinroth@google.com --- M src/mainboard/google/kahlee/variants/aleena/include/variant/ec.h 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/kahlee/variants/aleena/include/variant/ec.h b/src/mainboard/google/kahlee/variants/aleena/include/variant/ec.h index 12c6de6..0aa2e21 100644 --- a/src/mainboard/google/kahlee/variants/aleena/include/variant/ec.h +++ b/src/mainboard/google/kahlee/variants/aleena/include/variant/ec.h @@ -16,6 +16,9 @@ /* Enable EC backed Keyboard Backlight in ACPI */ #define EC_ENABLE_KEYBOARD_BACKLIGHT
+/* Enable Tablet switch */ +#define EC_ENABLE_TBMC_DEVICE + /* * Enable EC sync interrupt via GPIO controller, EC_SYNC_IRQ is defined in * variant/gpio.h
-
Edward Hill (Code Review) -
Furquan Shaikh (Code Review)
-
Martin Roth (Code Review)