Change in coreboot[master]: domain_acpi_name function missing in 00660F01 northbridge.

[Name of user not set (Code Review)]

Name of user not set #1002701 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37547 )

Change subject: domain_acpi_name function missing in 00660F01 northbridge.
......................................................................

domain_acpi_name function missing in 00660F01 northbridge.

Change-Id: I1ee439213ff128b534f5bf130661d0ae2b9558ab
Signed-off-by: Jorge Fernandez 
---
M src/northbridge/amd/pi/00660F01/northbridge.c
1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/37547/1

diff --git a/src/northbridge/amd/pi/00660F01/northbridge.c b/src/northbridge/amd/pi/00660F01/northbridge.c
index 723e6f4..b1226a3 100644
--- a/src/northbridge/amd/pi/00660F01/northbridge.c
+++ b/src/northbridge/amd/pi/00660F01/northbridge.c
@@ -769,12 +769,21 @@
    }
 }

+static const char *domain_acpi_name(const struct device *dev)
+{
+	if (dev->path.type == DEVICE_PATH_DOMAIN)
+		return "PCI0";
+
+	return NULL;
+}
+
 static struct device_operations pci_domain_ops = {
    .read_resources	  = domain_read_resources,
    .set_resources	  = domain_set_resources,
    .enable_resources = domain_enable_resources,
    .init		  = NULL,
    .scan_bus	  = pci_domain_scan_bus,
+	.acpi_name	  = domain_acpi_name,
 };

static void sysconf_init(struct device *dev) // first node

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37547 )

Change subject: domain_acpi_name function missing in 00660F01 northbridge.
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37547/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37547/1//COMMIT_MSG@7 
PS1, Line 7: domain_acpi_name function missing in 00660F01 northbridge.
Please rephrase:
> amd/pi/00660F01: Add missing domain_acpi_name function

https://review.coreboot.org/c/coreboot/+/37547/1//COMMIT_MSG@8 
PS1, Line 8: 
Please describe the error/problem.

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37547 )

Change subject: domain_acpi_name function missing in 00660F01 northbridge.
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37547/1/src/northbridge/amd/pi/0066... 
File src/northbridge/amd/pi/00660F01/northbridge.c:

https://review.coreboot.org/c/coreboot/+/37547/1/src/northbridge/amd/pi/0066... 
PS1, Line 779: 
Looks reasonable to me.

[Name of user not set (Code Review)]

Name of user not set #1002701 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37547 )

Change subject: domain_acpi_name function missing in 00660F01 northbridge.
......................................................................

Patch Set 1:
> Patch Set 1:
>
> (2 comments)

Sorry, what do you mean with rephrase?
If I remmember ok, this patch was needed in order to enable the sata boot. It's symmetric to 00730F01.

[Name of user not set (Code Review)]

Name of user not set #1002701 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37547 )

Change subject: domain_acpi_name function missing in 00660F01 northbridge.
......................................................................

Patch Set 1:
> Patch Set 1:
> > Patch Set 1:
> >
> > (2 comments)
>
> Sorry, what do you mean with rephrase?

Do you mean to change to northbridge/amd/pi/00660F01 to follow the git log --oneline convention? Sorry, I'm just arrive...

Change in coreboot[master]: northbridge/amd/pi/00660F01: domain_acpi_name function missing in nor...

[Name of user not set (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37547

to look at the new patch set (#2).

Change subject: northbridge/amd/pi/00660F01: domain_acpi_name function missing in northbridge.
......................................................................

northbridge/amd/pi/00660F01: domain_acpi_name function missing in northbridge.

This patch was needed in order to enable the sata boot in the AMD Bettong board. It's symmetric to the code found in 00730F01 northbridge.

Change-Id: I1ee439213ff128b534f5bf130661d0ae2b9558ab
Signed-off-by: Jorge Fernandez 
---
M src/northbridge/amd/pi/00660F01/northbridge.c
1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/37547/2

Change in coreboot[master]: northbridge/amd/pi/00660F01: domain_acpi_name function missing in nor...

[Name of user not set (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37547

to look at the new patch set (#3).

Change subject: northbridge/amd/pi/00660F01: domain_acpi_name function missing in northbridge
......................................................................

northbridge/amd/pi/00660F01: domain_acpi_name function missing in northbridge

This patch was needed in order to enable the sata boot in the AMD Bettong board. It's symmetric to the code found in 00730F01 northbridge.

Change-Id: I1ee439213ff128b534f5bf130661d0ae2b9558ab
Signed-off-by: Jorge Fernandez 
---
M src/northbridge/amd/pi/00660F01/northbridge.c
1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/37547/3

Change in coreboot[master]: northbridge/amd/pi/00660F01: domain_acpi_name function missing in nor...

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37547 )

Change subject: northbridge/amd/pi/00660F01: domain_acpi_name function missing in northbridge
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37547/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37547/1//COMMIT_MSG@7 
PS1, Line 7: domain_acpi_name function missing in 00660F01 northbridge.
> Please rephrase: […]

In PS3 "northbridge/amd/pi/00660F01: domain_acpi_name function missing in northbridge" is a very long subject line.  I agree with Paul's suggestion.

https://review.coreboot.org/c/coreboot/+/37547/1//COMMIT_MSG@8 
PS1, Line 8:
> Please describe the error/problem.

Was this actually required for SATA to boot?  Or is the info about SATA unrelated?

Change in coreboot[master]: amd/pi/00660F01: Add missing domain_acpi_name function

[Jorge Fernandez (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37547

to look at the new patch set (#4).

Change subject: amd/pi/00660F01: Add missing domain_acpi_name function
......................................................................

amd/pi/00660F01: Add missing domain_acpi_name function

It's symmetric to the code found in 00730F01 northbridge.

Change-Id: I1ee439213ff128b534f5bf130661d0ae2b9558ab
Signed-off-by: Jorge Fernandez 
---
M src/northbridge/amd/pi/00660F01/northbridge.c
1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/37547/4

Change in coreboot[master]: amd/pi/00660F01: Add missing domain_acpi_name function

[Jorge Fernandez (Code Review)]

Jorge Fernandez has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37547 )

Change subject: amd/pi/00660F01: Add missing domain_acpi_name function
......................................................................

Patch Set 4:
> Patch Set 3:
>
> (2 comments)

You're right. I've tested again without the patch and SATA boots ok. I don't remember why I need this patch but I think it doesn't hurts. I've changed the commit message accordingly.

Change in coreboot[master]: amd/pi/00660F01: Add missing domain_acpi_name function

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37547 )

Change subject: amd/pi/00660F01: Add missing domain_acpi_name function
......................................................................

Patch Set 4: Code-Review+2

Change in coreboot[master]: amd/pi/00660F01: Add missing domain_acpi_name function

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37547 )

Change subject: amd/pi/00660F01: Add missing domain_acpi_name function
......................................................................

Patch Set 4: Code-Review+1

Those have also missing domain_acpi_name function ?
src/northbridge/amd/agesa/family15tn/northbridge.c
src/northbridge/amd/pi/00630F01/northbridge.c

Change in coreboot[master]: amd/pi/00660F01: Add missing domain_acpi_name function

[Jorge Fernandez (Code Review)]

Jorge Fernandez has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37547 )

Change subject: amd/pi/00660F01: Add missing domain_acpi_name function
......................................................................

Patch Set 4:
> Patch Set 4:
> > Patch Set 3:
> >
> > (2 comments)
>
> You're right. I've tested again without the patch and SATA boots ok. I don't remember why I need this patch but I think it doesn't hurts. I've changed the commit message accordingly.

I've found the thread in the coreboot mailing list where I reported the error I got trying to initialize the TPM and this patch was the solution.

Change in coreboot[master]: amd/pi/00660F01: Add missing domain_acpi_name function

[Jorge Fernandez (Code Review)]

Jorge Fernandez has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37547 )

Change subject: amd/pi/00660F01: Add missing domain_acpi_name function
......................................................................

Patch Set 4:
> Patch Set 4:
> > Patch Set 4:
> > > Patch Set 3:
> > >
> > > (2 comments)
> >
> > You're right. I've tested again without the patch and SATA boots ok. I don't remember why I need this patch but I think it doesn't hurts. I've changed the commit message accordingly.
>
> I've found the thread in the coreboot mailing list where I reported the error I got trying to initialize the TPM and this patch was the solution.

https://mail.coreboot.org/hyperkitty/list/[e-mail]/thread/N7P6W...

Change in coreboot[master]: amd/pi/00660F01: Add missing domain_acpi_name function

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37547 )

Change subject: amd/pi/00660F01: Add missing domain_acpi_name function
......................................................................

Patch Set 4:
> > > You're right. I've tested again without the patch and SATA boots ok. I don't remember why I need this patch but I think it doesn't hurts. I've changed the commit message accordingly.
> >
> > I've found the thread in the coreboot mailing list where I reported the error I got trying to initialize the TPM and this patch was the solution.
>
> https://mail.coreboot.org/hyperkitty/list/[e-mail]/thread/N7P6W...

Please document that in the commit message.

Change in coreboot[master]: amd/pi/00660F01: Add missing domain_acpi_name function

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37547 )

Change subject: amd/pi/00660F01: Add missing domain_acpi_name function
......................................................................

Patch Set 4:

ping :)

Change in coreboot[master]: amd/pi/00660F01: Add missing domain_acpi_name function

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37547 )

Change subject: amd/pi/00660F01: Add missing domain_acpi_name function
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37547/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37547/1//COMMIT_MSG@7 
PS1, Line 7: domain_acpi_name function missing in 00660F01 northbridge.
> In PS3 "northbridge/amd/pi/00660F01: domain_acpi_name function missing in northbridge" is a very lon […]

Done

https://review.coreboot.org/c/coreboot/+/37547/1//COMMIT_MSG@8 
PS1, Line 8:
> Was this actually required for SATA to boot?  Or is the info about SATA unrelated?

Done

Change in coreboot[master]: amd/pi/00660F01: Add missing domain_acpi_name function

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37547 )

Change subject: amd/pi/00660F01: Add missing domain_acpi_name function
......................................................................

amd/pi/00660F01: Add missing domain_acpi_name function

It's symmetric to the code found in 00730F01 northbridge.

Change-Id: I1ee439213ff128b534f5bf130661d0ae2b9558ab
Signed-off-by: Jorge Fernandez 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37547
Reviewed-by: Marshall Dawson 
Reviewed-by: HAOUAS Elyes 
Tested-by: build bot (Jenkins) 
---
M src/northbridge/amd/pi/00660F01/northbridge.c
1 file changed, 9 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  HAOUAS Elyes: Looks good to me, but someone else must approve
  Marshall Dawson: Looks good to me, approved

diff --git a/src/northbridge/amd/pi/00660F01/northbridge.c b/src/northbridge/amd/pi/00660F01/northbridge.c
index 16b5734..3e04ec3 100644
--- a/src/northbridge/amd/pi/00660F01/northbridge.c
+++ b/src/northbridge/amd/pi/00660F01/northbridge.c
@@ -757,12 +757,21 @@
    }
 }

+static const char *domain_acpi_name(const struct device *dev)
+{
+	if (dev->path.type == DEVICE_PATH_DOMAIN)
+		return "PCI0";
+
+	return NULL;
+}
+
 static struct device_operations pci_domain_ops = {
    .read_resources	  = domain_read_resources,
    .set_resources	  = domain_set_resources,
    .enable_resources = domain_enable_resources,
    .init		  = NULL,
    .scan_bus	  = pci_domain_scan_bus,
+	.acpi_name	  = domain_acpi_name,
 };

static void sysconf_init(struct device *dev) // first node