Attention is currently required from: Arthur Heymans, Christian Walter, Nico Huber.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49461?usp=email )
Change subject: payloads/external/seabios: Scan all PCI domains on Xeon-SP platforms ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49461/comment/e4a670ce_cfab8ab9 : PS2, Line 7: PCI domains
There is no such thing as a "PCI domain". The term is sometimes wrongly […]
Done
https://review.coreboot.org/c/coreboot/+/49461/comment/0e03262c_8593671b : PS2, Line 10: domain 0
`the first host bridge`?
Done
File payloads/external/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/49461/comment/6d565c45_20c67511 : PS2, Line 117: domains
I tried to explain this below. It controls the maximum number of […]
Done
https://review.coreboot.org/c/coreboot/+/49461/comment/b88e9883_3dd562db : PS2, Line 118: $(CBFSTOOL) $< add-int -i 255 -n etc/extra-pci-roots
Can you add "$(if $(CONFIG_UPDATE_IMAGE),-$(CBFSTOOL) $< remove -n etc/extra-pci-roots 2>/dev/null)" […]
Christian, are you interested in fixing this one? Or should we abandon?