Attention is currently required from: Nico Huber, Angel Pons, Patrick Rudolph. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61938 )
Change subject: nb/intel/ironlake: Fix sending HECI messages ......................................................................
Patch Set 7:
(2 comments)
File src/northbridge/intel/ironlake/raminit.c:
https://review.coreboot.org/c/coreboot/+/61938/comment/27b68b45_c8b41e9b PS5, Line 1539: length - i < sizeof(dword) ? length - i : sizeof(dword)
is it?
Oh my bad. I must have forgotting to commit my change locally.
File src/southbridge/intel/ibexpeak/setup_heci_uma.c:
https://review.coreboot.org/c/coreboot/+/61938/comment/632fd9f2_a193dc4a PS7, Line 54: (head->length - 1) / sizeof(u32)
This used to be rounded up and + 1 (for the head I guess), iow. the number of writes we are going to do to DEFAULT_HECIBAR+0. I don't understand the change. If I didn't miss anything:
wait_heci_cb_avail(DIV_RONUD_UP(sizeof(*head) + head->length, sizeof(u32)));
Got it. Thanks.