Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Meera Ravindranath.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56926 )
Change subject: mb/google/brya: Fix Idle S0ix issue due to dynamic GPIO PM disabled
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56926/comment/b5460552_28c90eda
PS7, Line 9: GPIO PM was disabled for brya to evaluate if longer interrupt pulses
: are required for ADL.Since ADL requires 4us long pulses(EDS:626817),
: GPIO PM can be enabled.All devices currently tested on brya support 4us
: long pulses.This change drops the GPIO PM override and
: re-enables dynamic GPIO PM.
:
Spaces after periods and before `(` please
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56926
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c7b66b5514d8b80775ab7578ce7b12181af7882
Gerrit-Change-Number: 56926
Gerrit-PatchSet: 7
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Comment-Date: Wed, 01 Sep 2021 15:12:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment