Change in coreboot[master]: mb/ocp/tiogapass: Add SMBIOS type8 data table

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Bryant Ou (Code Review)

21 Apr 2020 21 Apr '20

6:14 a.m.

Bryant Ou has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40547 )

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

mb/ocp/tiogapass: Add SMBIOS type8 data table

According to MP MB to port SMBIOS type8 data.

Tested=Use "dmidecoe -t 8" to dump SMBIOS data, and check if type8 tables are implemented.

Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Signed-off-by: BryantOu Bryant.Ou.Q@gmail.com --- M src/mainboard/ocp/tiogapass/ramstage.c 1 file changed, 130 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/40547/1

diff --git a/src/mainboard/ocp/tiogapass/ramstage.c b/src/mainboard/ocp/tiogapass/ramstage.c index 16b4fd9..a6ca01d 100644 --- a/src/mainboard/ocp/tiogapass/ramstage.c +++ b/src/mainboard/ocp/tiogapass/ramstage.c @@ -16,11 +16,141 @@ #include <bootstate.h> #include <gpio.h> #include <soc/lewisburg_pch_gpio_defs.h> +#include <smbios.h>

void mainboard_silicon_init_params(FSPS_UPD *params) { }

+static const struct port_information SMBIOS_type8_info[] = { + /* + * Port Information fields: + * Internal Reference Designator, + * Internal Connector Type, + * External Reference Designator, + * External Connector_Type, + * Port Type + */ + { + "J7F5 - BMC JTAG HEADER", + CONN_OTHER, + 0, + CONN_NONE, + TYPE_OTHER + }, + { + "J8A1 - MINISAS1", + CONN_SAS_SATA, + 0, + CONN_NONE, + TYPE_SAS + }, + { + "J8A2 - MINISAS2", + CONN_SAS_SATA, + 0, + CONN_NONE, + TYPE_SAS + }, + { + "J8A3 - SATA CONBINE1", + CONN_SAS_SATA, + 0, + CONN_NONE, + TYPE_SAS + }, + { + "J8B1 - ME_DBG", + CONN_OTHER, + 0, + CONN_NONE, + TYPE_OTHER + }, + { + "J8D1 - VR_DBG", + CONN_OTHER, + 0, + CONN_NONE, + TYPE_OTHER + }, + { + "J8E1 - TPM_MODULE", + CONN_OTHER, + 0, + CONN_NONE, + TYPE_OTHER + }, + { + "J8F1 - M.2 CONNECTOR", + CONN_OTHER, + 0, + CONN_NONE, + TYPE_OTHER + }, + { + "J9A1 - SATA RAID KEY", + CONN_OTHER, + 0, + CONN_NONE, + TYPE_OTHER + }, + { + 0, + CONN_NONE, + "J9A2 - DEBUG 80 PORT", + CONN_OTHER, + TYPE_OTHER + }, + { + "J9A3 - CPU & PCH XDP", + CONN_OTHER, + 0, + CONN_NONE, + TYPE_OTHER + }, + { + 0, + CONN_NONE, + "J9A5 - USB conn", + CONN_ACCESS_BUS_USB, + TYPE_USB + }, + { + "J9B1 - BMC_DBG", + CONN_OTHER, + 0, + CONN_NONE, + TYPE_OTHER + }, + { + 0, + CONN_NONE, + "J9D1 - USB3.0 TYPE C", + CONN_ACCESS_BUS_USB, + TYPE_USB + }, + { + 0, + CONN_NONE, + "J9E1 - VGA", + CONN_OTHER, + TYPE_OTHER + }, + { + 0, + CONN_NONE, + "JA9G1 - ETH0", + CONN_RJ_45, + TYPE_NETWORK_PORT + }, +}; + +const struct port_information *__weak smbios_get_port_info(size_t *num_port) +{ + *num_port = ARRAY_SIZE(SMBIOS_type8_info); + return SMBIOS_type8_info; +} + static void pull_post_complete_pin(void *unused) { /* Pull Low post complete pin */

Attachments:

attachment.htm (text/html — 11.0 KB)

Show replies by date

build bot (Jenkins) (Code Review)

21 Apr 21 Apr

6:14 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40547 )

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

Patch Set 1:

(5 comments)

https://review.coreboot.org/c/coreboot/+/40547/1/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/ramstage.c:

https://review.coreboot.org/c/coreboot/+/40547/1/src/mainboard/ocp/tiogapass... PS1, Line 28: * Internal Reference Designator, please, no space before tabs

https://review.coreboot.org/c/coreboot/+/40547/1/src/mainboard/ocp/tiogapass... PS1, Line 29: * Internal Connector Type, please, no space before tabs

https://review.coreboot.org/c/coreboot/+/40547/1/src/mainboard/ocp/tiogapass... PS1, Line 30: * External Reference Designator, please, no space before tabs

https://review.coreboot.org/c/coreboot/+/40547/1/src/mainboard/ocp/tiogapass... PS1, Line 31: * External Connector_Type, please, no space before tabs

https://review.coreboot.org/c/coreboot/+/40547/1/src/mainboard/ocp/tiogapass... PS1, Line 32: * Port Type please, no space before tabs

Bryant Ou (Code Review)

6:16 a.m.

Bryant Ou has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/40547 )

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

mb/ocp/tiogapass: Add SMBIOS type8 data table

According to MP MB to port SMBIOS type8 data.

Tested=Use "dmidecoe -t 8" to dump SMBIOS data, and check if type8 tables are implemented.

Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Signed-off-by: BryantOu Bryant.Ou.Q@gmail.com --- M src/mainboard/ocp/tiogapass/ramstage.c 1 file changed, 130 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/40547/2

Bryant Ou (Code Review)

6:19 a.m.

Bryant Ou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40547 )

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

Patch Set 2:

(5 comments)

...

Patch Set 1:

(5 comments)

https://review.coreboot.org/c/coreboot/+/40547/1/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/ramstage.c:

https://review.coreboot.org/c/coreboot/+/40547/1/src/mainboard/ocp/tiogapass... PS1, Line 28: * Internal Reference Designator,

...

please, no space before tabs

Done

https://review.coreboot.org/c/coreboot/+/40547/1/src/mainboard/ocp/tiogapass... PS1, Line 29: * Internal Connector Type,

...

please, no space before tabs

Done

https://review.coreboot.org/c/coreboot/+/40547/1/src/mainboard/ocp/tiogapass... PS1, Line 30: * External Reference Designator,

...

please, no space before tabs

Done

https://review.coreboot.org/c/coreboot/+/40547/1/src/mainboard/ocp/tiogapass... PS1, Line 31: * External Connector_Type,

...

please, no space before tabs

Done

https://review.coreboot.org/c/coreboot/+/40547/1/src/mainboard/ocp/tiogapass... PS1, Line 32: * Port Type

...

please, no space before tabs

Done

Bryant Ou (Code Review)

7:30 a.m.

Hello build bot (Jenkins), Andrey Petrov, Jonathan Zhang, Ryback Hung, David Hendricks, Tim Chu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40547

to look at the new patch set (#3).

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

mb/ocp/tiogapass: Add SMBIOS type8 data table

According to MP MB to port SMBIOS type8 data.

Tested=Use "dmidecoe -t 8" to dump SMBIOS data, and check if type8 tables are implemented.

Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Signed-off-by: BryantOu Bryant.Ou.Q@gmail.com --- M src/mainboard/ocp/tiogapass/ramstage.c 1 file changed, 130 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/40547/3

Jonathan Zhang (Code Review)

8 May 8 May

2:54 a.m.

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40547 )

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 3 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 08 May 2020 00:54:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Bryant Ou (Code Review)

6:23 a.m.

Hello build bot (Jenkins), Andrey Petrov, Jonathan Zhang, Ryback Hung, David Hendricks, Tim Chu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40547

to look at the new patch set (#4).

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

mb/ocp/tiogapass: Add SMBIOS type8 data table

According to MP MB to port SMBIOS type8 data.

Tested=Use "dmidecoe -t 8" to dump SMBIOS data, and check if type8 tables are implemented.

Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Signed-off-by: BryantOu Bryant.Ou.Q@gmail.com --- M src/mainboard/ocp/tiogapass/ramstage.c 1 file changed, 130 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/40547/4

Bryant Ou (Code Review)

11 May 11 May

5:32 a.m.

Hello build bot (Jenkins), Andrey Petrov, Jonathan Zhang, Ryback Hung, David Hendricks, Tim Chu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40547

to look at the new patch set (#5).

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

mb/ocp/tiogapass: Add SMBIOS type8 data table

According to MP MB to port SMBIOS type8 data.

Tested=Use "dmidecoe -t 8" to dump SMBIOS data, and check if type8 tables are implemented.

Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Signed-off-by: BryantOu Bryant.Ou.Q@gmail.com --- M src/mainboard/ocp/tiogapass/Makefile.inc A src/mainboard/ocp/tiogapass/mainboard.c 2 files changed, 157 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/40547/5

Bryant Ou (Code Review)

5:35 a.m.

Bryant Ou has removed Patrick Georgi from this change. ( https://review.coreboot.org/c/coreboot/+/40547 )

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

Removed reviewer Patrick Georgi.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 5 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: deleteReviewer

Bryant Ou (Code Review)

5:35 a.m.

Bryant Ou has removed Martin Roth from this change. ( https://review.coreboot.org/c/coreboot/+/40547 )

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

Removed reviewer Martin Roth.

HAOUAS Elyes (Code Review)

5 Jul 5 Jul

11:10 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40547 )

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40547/5/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/mainboard.c:

https://review.coreboot.org/c/coreboot/+/40547/5/src/mainboard/ocp/tiogapass... PS5, Line 2: /* This file is part of the coreboot project. */ please, remove

https://review.coreboot.org/c/coreboot/+/40547/5/src/mainboard/ocp/tiogapass... PS5, Line 20: TYPE_OTHER TYPE_OTHER_PORT

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 5 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 05 Jul 2020 09:10:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

21 Jul 21 Jul

12:21 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40547 )

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

Patch Set 5: Code-Review+1

This would need to be rebased

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 5 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jul 2020 10:21:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Bryant Ou (Code Review)

23 Jul 23 Jul

5:09 a.m.

Hello build bot (Jenkins), Andrey Petrov, Jonathan Zhang, Ryback Hung, David Hendricks, Angel Pons, Tim Chu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40547

to look at the new patch set (#6).

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

mb/ocp/tiogapass: Add SMBIOS type8 data table

According to MP MB to port SMBIOS type8 data.

Tested=Use "dmidecoe -t 8" to dump SMBIOS data, and check if type8 tables are implemented.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/40547/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 6 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Bryant Ou (Code Review)

5:11 a.m.

Bryant Ou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40547 )

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40547/5/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/mainboard.c:

https://review.coreboot.org/c/coreboot/+/40547/5/src/mainboard/ocp/tiogapass... PS5, Line 2: /* This file is part of the coreboot project. */

...

please, remove

Done

https://review.coreboot.org/c/coreboot/+/40547/5/src/mainboard/ocp/tiogapass... PS5, Line 20: TYPE_OTHER

...

TYPE_OTHER_PORT

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 6 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 23 Jul 2020 03:11:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

Angel Pons (Code Review)

10:20 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40547 )

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 6 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 23 Jul 2020 08:20:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

11:09 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40547 )

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40547/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40547/6//COMMIT_MSG@11 PS6, Line 11: dmidecoe dmideco*d*e

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 6 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 23 Jul 2020 09:09:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Bryant Ou (Code Review)

24 Jul 24 Jul

3:04 a.m.

Hello build bot (Jenkins), Andrey Petrov, Patrick Georgi, Martin Roth, Jonathan Zhang, Ryback Hung, David Hendricks, Angel Pons, Tim Chu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40547

to look at the new patch set (#7).

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

mb/ocp/tiogapass: Add SMBIOS type8 data table

According to MP MB to port SMBIOS type8 data.

Tested=Use "dmidecode -t 8" to dump SMBIOS data, and check if type8 tables are implemented.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/40547/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 7 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Bryant Ou (Code Review)

3:04 a.m.

Bryant Ou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40547 )

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40547/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40547/6//COMMIT_MSG@11 PS6, Line 11: dmidecoe

...

dmideco*d*e

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 7 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 24 Jul 2020 01:04:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

11:51 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40547 )

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

Patch Set 7:

This needs a manual rebase now 😞

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 7 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 24 Jul 2020 09:51:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Bryant Ou (Code Review)

27 Jul 27 Jul

3:26 a.m.

Hello build bot (Jenkins), Andrey Petrov, Patrick Georgi, Martin Roth, Jonathan Zhang, Ryback Hung, David Hendricks, Angel Pons, Tim Chu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40547

to look at the new patch set (#8).

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

mb/ocp/tiogapass: Add SMBIOS type8 data table

According to MP MB to port SMBIOS type8 data.

Tested=Use "dmidecode -t 8" to dump SMBIOS data, and check if type8 tables are implemented.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/40547/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 8 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Bryant Ou (Code Review)

4:23 a.m.

Hello build bot (Jenkins), Andrey Petrov, Patrick Georgi, Martin Roth, Jonathan Zhang, Ryback Hung, David Hendricks, Angel Pons, Tim Chu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40547

to look at the new patch set (#9).

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

mb/ocp/tiogapass: Add SMBIOS type8 data table

According to MP MB to port SMBIOS type8 data.

Tested=Use "dmidecode -t 8" to dump SMBIOS data, and check if type8 tables are implemented.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/40547/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 9 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Bryant Ou (Code Review)

5:04 a.m.

Hello build bot (Jenkins), Andrey Petrov, Patrick Georgi, Martin Roth, Jonathan Zhang, Ryback Hung, David Hendricks, Angel Pons, Tim Chu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40547

to look at the new patch set (#10).

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

mb/ocp/tiogapass: Add SMBIOS type8 data table

According to MP MB to port SMBIOS type8 data.

Tested=Use "dmidecode -t 8" to dump SMBIOS data, and check if type8 tables are implemented.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/40547/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 10 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

3:12 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40547 )

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

Patch Set 11: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/40547/11/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/mainboard.c:

https://review.coreboot.org/c/coreboot/+/40547/11/src/mainboard/ocp/tiogapas... PS11, Line 152: mainboard_ops This is defined multiple times now.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 11 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 27 Jul 2020 13:12:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Bryant Ou (Code Review)

28 Jul 28 Jul

3:14 a.m.

Hello build bot (Jenkins), Andrey Petrov, Patrick Georgi, Martin Roth, Jonathan Zhang, Ryback Hung, David Hendricks, Angel Pons, Tim Chu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40547

to look at the new patch set (#12).

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

mb/ocp/tiogapass: Add SMBIOS type8 data table

According to MP MB to port SMBIOS type8 data.

Tested=Use "dmidecode -t 8" to dump SMBIOS data, and check if type8 tables are implemented.

Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Signed-off-by: BryantOu Bryant.Ou.Q@gmail.com --- M src/mainboard/ocp/tiogapass/ramstage.c 1 file changed, 141 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/40547/12

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 12 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

11:04 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40547 )

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

Patch Set 12: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/40547/11/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/mainboard.c:

https://review.coreboot.org/c/coreboot/+/40547/11/src/mainboard/ocp/tiogapas... PS11, Line 152: mainboard_ops

...

This is defined multiple times now.

Done

https://review.coreboot.org/c/coreboot/+/40547/12/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/ramstage.c:

https://review.coreboot.org/c/coreboot/+/40547/12/src/mainboard/ocp/tiogapas... PS12, Line 27: 0 NULL

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 12 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 28 Jul 2020 09:04:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Bryant Ou (Code Review)

29 Jul 29 Jul

2:50 a.m.

Hello build bot (Jenkins), Andrey Petrov, Patrick Georgi, Martin Roth, Jonathan Zhang, Ryback Hung, David Hendricks, Angel Pons, Tim Chu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40547

to look at the new patch set (#13).

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

mb/ocp/tiogapass: Add SMBIOS type8 data table

According to MP MB to port SMBIOS type8 data.

Tested=Use "dmidecode -t 8" to dump SMBIOS data, and check if type8 tables are implemented.

Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Signed-off-by: BryantOu Bryant.Ou.Q@gmail.com --- M src/mainboard/ocp/tiogapass/ramstage.c 1 file changed, 141 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/40547/13

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 13 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Bryant Ou (Code Review)

2:51 a.m.

Bryant Ou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40547 )

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40547/12/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/ramstage.c:

https://review.coreboot.org/c/coreboot/+/40547/12/src/mainboard/ocp/tiogapas... PS12, Line 27: 0

...

NULL

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 13 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 29 Jul 2020 00:51:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

10:38 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40547 )

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

Patch Set 13: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 13 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 29 Jul 2020 08:38:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

30 Jul 30 Jul

11:18 a.m.

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40547 )

Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................

mb/ocp/tiogapass: Add SMBIOS type8 data table

According to MP MB to port SMBIOS type8 data.

Tested=Use "dmidecode -t 8" to dump SMBIOS data, and check if type8 tables are implemented.

Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Signed-off-by: BryantOu Bryant.Ou.Q@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40547 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/ocp/tiogapass/ramstage.c 1 file changed, 141 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/ocp/tiogapass/ramstage.c b/src/mainboard/ocp/tiogapass/ramstage.c index f02667b..0e520f0 100644 --- a/src/mainboard/ocp/tiogapass/ramstage.c +++ b/src/mainboard/ocp/tiogapass/ramstage.c @@ -12,6 +12,129 @@

extern struct fru_info_str fru_strings;

+static const struct port_information SMBIOS_type8_info[] = { + /* + * Port Information fields: + * Internal Reference Designator, + * Internal Connector Type, + * External Reference Designator, + * External Connector_Type, + * Port Type + */ + { + "J7F5 - BMC JTAG HEADER", + CONN_OTHER, + NULL, + CONN_NONE, + TYPE_OTHER_PORT + }, + { + "J8A1 - MINISAS1", + CONN_SAS_SATA, + NULL, + CONN_NONE, + TYPE_SAS + }, + { + "J8A2 - MINISAS2", + CONN_SAS_SATA, + NULL, + CONN_NONE, + TYPE_SAS + }, + { + "J8A3 - SATA CONBINE1", + CONN_SAS_SATA, + NULL, + CONN_NONE, + TYPE_SAS + }, + { + "J8B1 - ME_DBG", + CONN_OTHER, + NULL, + CONN_NONE, + TYPE_OTHER_PORT + }, + { + "J8D1 - VR_DBG", + CONN_OTHER, + NULL, + CONN_NONE, + TYPE_OTHER_PORT + }, + { + "J8E1 - TPM_MODULE", + CONN_OTHER, + NULL, + CONN_NONE, + TYPE_OTHER_PORT + }, + { + "J8F1 - M.2 CONNECTOR", + CONN_OTHER, + NULL, + CONN_NONE, + TYPE_OTHER_PORT + }, + { + "J9A1 - SATA RAID KEY", + CONN_OTHER, + NULL, + CONN_NONE, + TYPE_OTHER_PORT + }, + { + NULL, + CONN_NONE, + "J9A2 - DEBUG 80 PORT", + CONN_OTHER, + TYPE_OTHER_PORT + }, + { + "J9A3 - CPU & PCH XDP", + CONN_OTHER, + NULL, + CONN_NONE, + TYPE_OTHER_PORT + }, + { + NULL, + CONN_NONE, + "J9A5 - USB conn", + CONN_ACCESS_BUS_USB, + TYPE_USB + }, + { + "J9B1 - BMC_DBG", + CONN_OTHER, + NULL, + CONN_NONE, + TYPE_OTHER_PORT + }, + { + NULL, + CONN_NONE, + "J9D1 - USB3.0 TYPE C", + CONN_ACCESS_BUS_USB, + TYPE_USB + }, + { + NULL, + CONN_NONE, + "J9E1 - VGA", + CONN_OTHER, + TYPE_OTHER_PORT + }, + { + NULL, + CONN_NONE, + "JA9G1 - ETH0", + CONN_RJ_45, + TYPE_NETWORK_PORT + }, +}; + void mainboard_silicon_init_params(FSPS_UPD *params) { } @@ -22,6 +145,21 @@ gpio_output(GPP_B20, 0); }

+#if CONFIG(GENERATE_SMBIOS_TABLES) +static int mainboard_smbios_data(struct device *dev, int *handle, unsigned long *current) +{ + int len = 0; + + // add port information + len += smbios_write_type8( + current, handle, + SMBIOS_type8_info, + ARRAY_SIZE(SMBIOS_type8_info) + ); + + return len; +} +#endif

static void tp_oem_smbios_strings(struct device *dev, struct smbios_type11 *t) { @@ -41,6 +179,9 @@ { dev->ops->get_smbios_strings = tp_oem_smbios_strings, read_fru_areas(CONFIG_BMC_KCS_BASE, CONFIG_FRU_DEVICE_ID, 0, &fru_strings); +#if CONFIG(GENERATE_SMBIOS_TABLES) + dev->ops->get_smbios_data = mainboard_smbios_data; +#endif }

static void mainboard_final(void *chip_info)

-- To view, visit https://review.coreboot.org/c/coreboot/+/40547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2 Gerrit-Change-Number: 40547 Gerrit-PatchSet: 14 Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1559

days inactive

1659

days old

coreboot-gerrit@coreboot.org

28 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Bryant Ou (Code Review)
build bot (Jenkins) (Code Review)
HAOUAS Elyes (Code Review)
Jonathan Zhang (Code Review)