Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76031?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for DdiPortDHpd dt option ......................................................................
mb/{cfl,cml,whl}: Use true/false macros for DdiPortDHpd dt option
The true/false macros give the reader a better understanding about how the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \ option="DdiPortDHpd" && \ grep -r "${dt_line}" src/mainboard | \ cut -d ':' -f 1 | \ xargs sed -i'' -e "s/"${option}".*=.*"1"/${option} = true/g" -e "s/"${option}".*=.*"0"/${option} = false/g"
Change-Id: I735713e5cef52aa98b1b9a74ae21ee92ea5d0e2e Signed-off-by: lilacious yuchenhe126@gmail.com --- M src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb M src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/76031/1
diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb index 30052c6..c5e0237 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb +++ b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb @@ -7,7 +7,7 @@ # Enable HPD for DDI ports B/C register DdiPortBHpd = true register DdiPortCHpd = true - register "DdiPortDHpd" = "1" + register DdiPortDHpd = true register "DdiPortFHpd" = "1" # Enable DDC for DDI ports B/C register "DdiPortBDdc" = "1" diff --git a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb index f1d4fda..1915879 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb +++ b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb @@ -7,7 +7,7 @@ # Enable HPD for DDI ports B/C/D/F register DdiPortBHpd = true register DdiPortCHpd = true - register "DdiPortDHpd" = "1" + register DdiPortDHpd = true register "DdiPortFHpd" = "1" # Enable DDC for DDI ports B/C/D/F register "DdiPortBDdc" = "1"