Attention is currently required from: Fred Reitberger, Jason Glenesk, Raul Rangel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76886?usp=email )
Change subject: soc/amd/common/include/data_fabric_defs: introduce & use DF_REG_* macros
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/block/include/amdblocks/data_fabric_defs.h:
https://review.coreboot.org/c/coreboot/+/76886/comment/40adde5f_9eb0f727 :
PS1, Line 6: 11 bits
had an off by one in my calculation, but at least the macros were correct
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76886?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63a284b26081c170a217b082b100c482f6158e7e
Gerrit-Change-Number: 76886
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Thu, 03 Aug 2023 14:05:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment