[XS] Change in coreboot[main]: mb/google/puff: Use auto fan control - coreboot-gerrit

12 Jul 2024


      Attention is currently required from: Felix Singer.
Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83410?usp=email )
Change subject: mb/google/puff: Use auto fan control
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83410/comment/cf8df4c1_c0cc730d?usp... :
PS2, Line 9: Set fan control to AUTO at boot for non-ChromeOS builds.
...
What does the fan do if not in auto mode? Does ChromeOS usually do the fan control?
it doesn't seem to ramp up properly with temp, at least under Windows.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83410?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I478cdb95757671d4ecd9c2d45af2aa1d53b4b833
Gerrit-Change-Number: 83410
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Comment-Date: Fri, 12 Jul 2024 19:48:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer service+coreboot-gerrit@felixsinger.de