Change in coreboot[master]: AGESA,binaryPI boards: Declare some IRQ tables static

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38261 )

Change subject: AGESA,binaryPI boards: Declare some IRQ tables static
......................................................................

AGESA,binaryPI boards: Declare some IRQ tables static

Change-Id: Ib45c6372df6068ab041a055dad8bacf597717ba2
Signed-off-by: Kyösti Mälkki 
---
M src/mainboard/amd/bettong/mainboard.c
M src/mainboard/amd/gardenia/mainboard.c
M src/mainboard/amd/lamar/mainboard.c
M src/mainboard/amd/padmelon/mainboard.c
M src/mainboard/asus/am1i-a/mainboard.c
M src/mainboard/bap/ode_e20XX/mainboard.c
M src/mainboard/biostar/am1ml/mainboard.c
M src/mainboard/gizmosphere/gizmo2/mainboard.c
M src/mainboard/google/kahlee/mainboard.c
9 files changed, 18 insertions(+), 18 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/38261/1

diff --git a/src/mainboard/amd/bettong/mainboard.c b/src/mainboard/amd/bettong/mainboard.c
index 5b93751..8e2ecfd 100644
--- a/src/mainboard/amd/bettong/mainboard.c
+++ b/src/mainboard/amd/bettong/mainboard.c
@@ -28,7 +28,7 @@
  * These values are used by the PCI configuration space,
  * MP Tables.  TODO: Make ACPI use these values too.
  */
-const u8 mainboard_picr_data[] = {
+static const u8 mainboard_picr_data[] = {
    [0x00] = 0x03,0x04,0x05,0x07,0x0B,0x0A,0x1F,0x1F,
    [0x08] = 0xFA,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
    [0x10] = 0x1F,0x1F,0x1F,0x03,0x1F,0x1F,0x1F,0x1F,
@@ -47,7 +47,7 @@
    [0x78] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,
 };

-const u8 mainboard_intr_data[] = {
+static const u8 mainboard_intr_data[] = {
    [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,
    [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
    [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x1F,0x1F,0x10,
diff --git a/src/mainboard/amd/gardenia/mainboard.c b/src/mainboard/amd/gardenia/mainboard.c
index 3a4090c..26c80c0 100644
--- a/src/mainboard/amd/gardenia/mainboard.c
+++ b/src/mainboard/amd/gardenia/mainboard.c
@@ -32,7 +32,7 @@
  * These values are used by the PCI configuration space,
  * MP Tables.  TODO: Make ACPI use these values too.
  */
-const u8 mainboard_picr_data[] = {
+static const u8 mainboard_picr_data[] = {
    [0x00] = 0x03, 0x04, 0x05, 0x07, 0x0B, 0x0A, 0x1F, 0x1F,
    [0x08] = 0xFA, 0xF1, 0x00, 0x00, 0x1F, 0x1F, 0x1F, 0x1F,
    [0x10] = 0x1F, 0x1F, 0x1F, 0x03, 0x1F, 0x1F, 0x1F, 0x1F,
@@ -51,7 +51,7 @@
    [0x78] = 0x1F, 0x1F, 0x1F, 0x1F, 0x1F, 0x1F, 0x1F, 0x1F,
 };

-const u8 mainboard_intr_data[] = {
+static const u8 mainboard_intr_data[] = {
    [0x00] = 0x10, 0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17,
    [0x08] = 0x00, 0x00, 0x00, 0x00, 0x1F, 0x1F, 0x1F, 0x1F,
    [0x10] = 0x09, 0x1F, 0x1F, 0x10, 0x1F, 0x1F, 0x1F, 0x10,
diff --git a/src/mainboard/amd/lamar/mainboard.c b/src/mainboard/amd/lamar/mainboard.c
index 2f716d0..264c603 100644
--- a/src/mainboard/amd/lamar/mainboard.c
+++ b/src/mainboard/amd/lamar/mainboard.c
@@ -35,7 +35,7 @@
  * These values are used by the PCI configuration space,
  * MP Tables.  TODO: Make ACPI use these values too.
  */
-const u8 mainboard_picr_data[] = {
+static const u8 mainboard_picr_data[] = {
    /* INTA# - INTH# */
    [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,
    /* Misc-nil,0,1,2, INT from Serial irq */
@@ -63,7 +63,7 @@
    [0x80] = 0x0C,0x1F,
 };

-const u8 mainboard_intr_data[] = {
+static const u8 mainboard_intr_data[] = {
    /* INTA# - INTH# */
    [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,
    /* Misc-nil,0,1,2, INT from Serial irq */
diff --git a/src/mainboard/amd/padmelon/mainboard.c b/src/mainboard/amd/padmelon/mainboard.c
index e106b4a..c8eef29 100644
--- a/src/mainboard/amd/padmelon/mainboard.c
+++ b/src/mainboard/amd/padmelon/mainboard.c
@@ -34,7 +34,7 @@
  * These values are used by the PCI configuration space,
  * MP Tables.
  */
-const u8 mainboard_picr_data[] = {
+static const u8 mainboard_picr_data[] = {
    [0x00] = 0x03, 0x04, 0x05, 0x07, 0x0B, 0x0A, 0x1F, 0x1F,
    [0x08] = 0xFA, 0xF1, 0x00, 0x00, 0x1F, 0x1F, 0x1F, 0x1F,
    [0x10] = 0x1F, 0x1F, 0x1F, 0x03, 0x1F, 0x1F, 0x1F, 0x1F,
@@ -53,7 +53,7 @@
    [0x78] = 0x1F, 0x1F, 0x1F, 0x1F, 0x1F, 0x1F, 0x1F, 0x1F,
 };

-const u8 mainboard_intr_data[] = {
+static const u8 mainboard_intr_data[] = {
    [0x00] = 0x10, 0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17,
    [0x08] = 0x00, 0x00, 0x00, 0x00, 0x1F, 0x1F, 0x1F, 0x1F,
    [0x10] = 0x09, 0x1F, 0x1F, 0x10, 0x1F, 0x1F, 0x1F, 0x10,
diff --git a/src/mainboard/asus/am1i-a/mainboard.c b/src/mainboard/asus/am1i-a/mainboard.c
index bd6d3a3..ecf4006 100644
--- a/src/mainboard/asus/am1i-a/mainboard.c
+++ b/src/mainboard/asus/am1i-a/mainboard.c
@@ -25,7 +25,7 @@
 #include <southbridge/amd/common/amd_pci_util.h>
 #include <northbridge/amd/agesa/family16kb/pci_devs.h>

-const u8 mainboard_picr_data[FCH_INT_TABLE_SIZE] = {
+static const u8 mainboard_picr_data[FCH_INT_TABLE_SIZE] = {
    /* INTA# - INTH# */
    [0x00] = 0x03,0x04,0x05,0x07,0x1F,0x1F,0x1F,0x1F,
    /* Misc-nil,0,1,2, INT from Serial irq */
@@ -40,7 +40,7 @@
    [0x40] = 0x1F, 0x07
 };

-const u8 mainboard_intr_data[FCH_INT_TABLE_SIZE] = {
+static const u8 mainboard_intr_data[FCH_INT_TABLE_SIZE] = {
    /* INTA# - INTH# */
    [0x00] = 0x10,0x11,0x12,0x13,0x1F,0x1F,0x1F,0x1F,
    /* Misc-nil,0,1,2, INT from Serial irq */
diff --git a/src/mainboard/bap/ode_e20XX/mainboard.c b/src/mainboard/bap/ode_e20XX/mainboard.c
index 6bd9445..2fcc1d6 100644
--- a/src/mainboard/bap/ode_e20XX/mainboard.c
+++ b/src/mainboard/bap/ode_e20XX/mainboard.c
@@ -34,7 +34,7 @@
  * These values are used by the PCI configuration space,
  * MP Tables.  TODO: Make ACPI use these values too.
  */
-const u8 mainboard_picr_data[FCH_INT_TABLE_SIZE] = {
+static const u8 mainboard_picr_data[FCH_INT_TABLE_SIZE] = {
    /* INTA# - INTH# */
    [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,
    /* Misc-nil,0,1,2, INT from Serial irq */
@@ -49,7 +49,7 @@
    [0x41] = 0x0F,
 };

-const u8 mainboard_intr_data[FCH_INT_TABLE_SIZE] = {
+static const u8 mainboard_intr_data[FCH_INT_TABLE_SIZE] = {
    /* INTA# - INTH# */
    [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,
    /* Misc-nil,0,1,2, INT from Serial irq */
diff --git a/src/mainboard/biostar/am1ml/mainboard.c b/src/mainboard/biostar/am1ml/mainboard.c
index 4db720e..9d218d8 100644
--- a/src/mainboard/biostar/am1ml/mainboard.c
+++ b/src/mainboard/biostar/am1ml/mainboard.c
@@ -23,7 +23,7 @@
 #include <southbridge/amd/common/amd_pci_util.h>
 #include <northbridge/amd/agesa/family16kb/pci_devs.h>

-const u8 mainboard_picr_data[FCH_INT_TABLE_SIZE] = {
+static const u8 mainboard_picr_data[FCH_INT_TABLE_SIZE] = {
    /* INTA# - INTH# */
    [0x00] = 0x03,0x04,0x05,0x07,0x0B,0x0A,0x1F,0x1F,
    /* Misc-nil,0,1,2, INT from Serial irq */
@@ -38,7 +38,7 @@
    [0x40] = 0x04, 0x04
 };

-const u8 mainboard_intr_data[FCH_INT_TABLE_SIZE] = {
+static const u8 mainboard_intr_data[FCH_INT_TABLE_SIZE] = {
    /* INTA# - INTH# */
    [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,
    /* Misc-nil,0,1,2, INT from Serial irq */
diff --git a/src/mainboard/gizmosphere/gizmo2/mainboard.c b/src/mainboard/gizmosphere/gizmo2/mainboard.c
index f856df9..a6c1a6d 100644
--- a/src/mainboard/gizmosphere/gizmo2/mainboard.c
+++ b/src/mainboard/gizmosphere/gizmo2/mainboard.c
@@ -33,7 +33,7 @@
  * These values are used by the PCI configuration space,
  * MP Tables.  TODO: Make ACPI use these values too.
  */
-const u8 mainboard_picr_data[FCH_INT_TABLE_SIZE] = {
+static const u8 mainboard_picr_data[FCH_INT_TABLE_SIZE] = {
    /* INTA# - INTH# */
    [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,
    /* Misc-nil,0,1,2, INT from Serial irq */
@@ -48,7 +48,7 @@
    [0x41] = 0x0F,
 };

-const u8 mainboard_intr_data[FCH_INT_TABLE_SIZE] = {
+static const u8 mainboard_intr_data[FCH_INT_TABLE_SIZE] = {
    /* INTA# - INTH# */
    [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,
    /* Misc-nil,0,1,2, INT from Serial irq */
diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c
index 0173064..42a82d4 100644
--- a/src/mainboard/google/kahlee/mainboard.c
+++ b/src/mainboard/google/kahlee/mainboard.c
@@ -45,7 +45,7 @@
  * MP Tables.  TODO: Make ACPI use these values too.
  */

-const u8 mainboard_picr_data[] = {
+static const u8 mainboard_picr_data[] = {
    [0x00] = 0x03, 0x04, 0x05, 0x07, 0x0B, 0x1F, 0x1F, 0x1F,
    [0x08] = 0xFA, 0xF1, 0x00, 0x00, 0x1F, 0x1F, 0x1F, 0x1F,
    [0x10] = 0x09, 0x1F, 0x1F, 0x03, 0x1F, 0x1F, 0x1F, 0x03,
@@ -64,7 +64,7 @@
    [0x78] = 0x1F, 0x1F, 0x1F, 0x1F, 0x1F, 0x1F, 0x1F, 0x1F,
 };

-const u8 mainboard_intr_data[] = {
+static const u8 mainboard_intr_data[] = {
    [0x00] = 0x10, 0x11, 0x12, 0x13, 0x14, 0x1F, 0x16, 0x17,
    [0x08] = 0x00, 0x00, 0x00, 0x00, 0x1F, 0x1F, 0x1F, 0x1F,
    [0x10] = 0x09, 0x1F, 0x1F, 0x10, 0x1F, 0x1F, 0x1F, 0x10,

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38261 )

Change subject: AGESA,binaryPI boards: Declare some IRQ tables static
......................................................................

Patch Set 1: Code-Review+1

[Michał Żygowski (Code Review)]

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38261 )

Change subject: AGESA,binaryPI boards: Declare some IRQ tables static
......................................................................

Patch Set 1: Code-Review+2

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38261 )

Change subject: AGESA,binaryPI boards: Declare some IRQ tables static
......................................................................

AGESA,binaryPI boards: Declare some IRQ tables static

Change-Id: Ib45c6372df6068ab041a055dad8bacf597717ba2
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38261
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Michał Żygowski 
---
M src/mainboard/amd/bettong/mainboard.c
M src/mainboard/amd/gardenia/mainboard.c
M src/mainboard/amd/lamar/mainboard.c
M src/mainboard/amd/padmelon/mainboard.c
M src/mainboard/asus/am1i-a/mainboard.c
M src/mainboard/bap/ode_e20XX/mainboard.c
M src/mainboard/biostar/am1ml/mainboard.c
M src/mainboard/gizmosphere/gizmo2/mainboard.c
M src/mainboard/google/kahlee/mainboard.c
9 files changed, 18 insertions(+), 18 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Michał Żygowski: Looks good to me, approved

diff --git a/src/mainboard/amd/bettong/mainboard.c b/src/mainboard/amd/bettong/mainboard.c
index 5b93751..8e2ecfd 100644
--- a/src/mainboard/amd/bettong/mainboard.c
+++ b/src/mainboard/amd/bettong/mainboard.c
@@ -28,7 +28,7 @@
  * These values are used by the PCI configuration space,
  * MP Tables.  TODO: Make ACPI use these values too.
  */
-const u8 mainboard_picr_data[] = {
+static const u8 mainboard_picr_data[] = {
    [0x00] = 0x03,0x04,0x05,0x07,0x0B,0x0A,0x1F,0x1F,
    [0x08] = 0xFA,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
    [0x10] = 0x1F,0x1F,0x1F,0x03,0x1F,0x1F,0x1F,0x1F,
@@ -47,7 +47,7 @@
    [0x78] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,
 };

-const u8 mainboard_intr_data[] = {
+static const u8 mainboard_intr_data[] = {
    [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,
    [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
    [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x1F,0x1F,0x10,
diff --git a/src/mainboard/amd/gardenia/mainboard.c b/src/mainboard/amd/gardenia/mainboard.c
index 3a4090c..26c80c0 100644
--- a/src/mainboard/amd/gardenia/mainboard.c
+++ b/src/mainboard/amd/gardenia/mainboard.c
@@ -32,7 +32,7 @@
  * These values are used by the PCI configuration space,
  * MP Tables.  TODO: Make ACPI use these values too.
  */
-const u8 mainboard_picr_data[] = {
+static const u8 mainboard_picr_data[] = {
    [0x00] = 0x03, 0x04, 0x05, 0x07, 0x0B, 0x0A, 0x1F, 0x1F,
    [0x08] = 0xFA, 0xF1, 0x00, 0x00, 0x1F, 0x1F, 0x1F, 0x1F,
    [0x10] = 0x1F, 0x1F, 0x1F, 0x03, 0x1F, 0x1F, 0x1F, 0x1F,
@@ -51,7 +51,7 @@
    [0x78] = 0x1F, 0x1F, 0x1F, 0x1F, 0x1F, 0x1F, 0x1F, 0x1F,
 };

-const u8 mainboard_intr_data[] = {
+static const u8 mainboard_intr_data[] = {
    [0x00] = 0x10, 0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17,
    [0x08] = 0x00, 0x00, 0x00, 0x00, 0x1F, 0x1F, 0x1F, 0x1F,
    [0x10] = 0x09, 0x1F, 0x1F, 0x10, 0x1F, 0x1F, 0x1F, 0x10,
diff --git a/src/mainboard/amd/lamar/mainboard.c b/src/mainboard/amd/lamar/mainboard.c
index 2f716d0..264c603 100644
--- a/src/mainboard/amd/lamar/mainboard.c
+++ b/src/mainboard/amd/lamar/mainboard.c
@@ -35,7 +35,7 @@
  * These values are used by the PCI configuration space,
  * MP Tables.  TODO: Make ACPI use these values too.
  */
-const u8 mainboard_picr_data[] = {
+static const u8 mainboard_picr_data[] = {
    /* INTA# - INTH# */
    [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,
    /* Misc-nil,0,1,2, INT from Serial irq */
@@ -63,7 +63,7 @@
    [0x80] = 0x0C,0x1F,
 };

-const u8 mainboard_intr_data[] = {
+static const u8 mainboard_intr_data[] = {
    /* INTA# - INTH# */
    [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,
    /* Misc-nil,0,1,2, INT from Serial irq */
diff --git a/src/mainboard/amd/padmelon/mainboard.c b/src/mainboard/amd/padmelon/mainboard.c
index e106b4a..c8eef29 100644
--- a/src/mainboard/amd/padmelon/mainboard.c
+++ b/src/mainboard/amd/padmelon/mainboard.c
@@ -34,7 +34,7 @@
  * These values are used by the PCI configuration space,
  * MP Tables.
  */
-const u8 mainboard_picr_data[] = {
+static const u8 mainboard_picr_data[] = {
    [0x00] = 0x03, 0x04, 0x05, 0x07, 0x0B, 0x0A, 0x1F, 0x1F,
    [0x08] = 0xFA, 0xF1, 0x00, 0x00, 0x1F, 0x1F, 0x1F, 0x1F,
    [0x10] = 0x1F, 0x1F, 0x1F, 0x03, 0x1F, 0x1F, 0x1F, 0x1F,
@@ -53,7 +53,7 @@
    [0x78] = 0x1F, 0x1F, 0x1F, 0x1F, 0x1F, 0x1F, 0x1F, 0x1F,
 };

-const u8 mainboard_intr_data[] = {
+static const u8 mainboard_intr_data[] = {
    [0x00] = 0x10, 0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17,
    [0x08] = 0x00, 0x00, 0x00, 0x00, 0x1F, 0x1F, 0x1F, 0x1F,
    [0x10] = 0x09, 0x1F, 0x1F, 0x10, 0x1F, 0x1F, 0x1F, 0x10,
diff --git a/src/mainboard/asus/am1i-a/mainboard.c b/src/mainboard/asus/am1i-a/mainboard.c
index bd6d3a3..ecf4006 100644
--- a/src/mainboard/asus/am1i-a/mainboard.c
+++ b/src/mainboard/asus/am1i-a/mainboard.c
@@ -25,7 +25,7 @@
 #include <southbridge/amd/common/amd_pci_util.h>
 #include <northbridge/amd/agesa/family16kb/pci_devs.h>

-const u8 mainboard_picr_data[FCH_INT_TABLE_SIZE] = {
+static const u8 mainboard_picr_data[FCH_INT_TABLE_SIZE] = {
    /* INTA# - INTH# */
    [0x00] = 0x03,0x04,0x05,0x07,0x1F,0x1F,0x1F,0x1F,
    /* Misc-nil,0,1,2, INT from Serial irq */
@@ -40,7 +40,7 @@
    [0x40] = 0x1F, 0x07
 };

-const u8 mainboard_intr_data[FCH_INT_TABLE_SIZE] = {
+static const u8 mainboard_intr_data[FCH_INT_TABLE_SIZE] = {
    /* INTA# - INTH# */
    [0x00] = 0x10,0x11,0x12,0x13,0x1F,0x1F,0x1F,0x1F,
    /* Misc-nil,0,1,2, INT from Serial irq */
diff --git a/src/mainboard/bap/ode_e20XX/mainboard.c b/src/mainboard/bap/ode_e20XX/mainboard.c
index 6bd9445..2fcc1d6 100644
--- a/src/mainboard/bap/ode_e20XX/mainboard.c
+++ b/src/mainboard/bap/ode_e20XX/mainboard.c
@@ -34,7 +34,7 @@
  * These values are used by the PCI configuration space,
  * MP Tables.  TODO: Make ACPI use these values too.
  */
-const u8 mainboard_picr_data[FCH_INT_TABLE_SIZE] = {
+static const u8 mainboard_picr_data[FCH_INT_TABLE_SIZE] = {
    /* INTA# - INTH# */
    [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,
    /* Misc-nil,0,1,2, INT from Serial irq */
@@ -49,7 +49,7 @@
    [0x41] = 0x0F,
 };

-const u8 mainboard_intr_data[FCH_INT_TABLE_SIZE] = {
+static const u8 mainboard_intr_data[FCH_INT_TABLE_SIZE] = {
    /* INTA# - INTH# */
    [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,
    /* Misc-nil,0,1,2, INT from Serial irq */
diff --git a/src/mainboard/biostar/am1ml/mainboard.c b/src/mainboard/biostar/am1ml/mainboard.c
index 4db720e..9d218d8 100644
--- a/src/mainboard/biostar/am1ml/mainboard.c
+++ b/src/mainboard/biostar/am1ml/mainboard.c
@@ -23,7 +23,7 @@
 #include <southbridge/amd/common/amd_pci_util.h>
 #include <northbridge/amd/agesa/family16kb/pci_devs.h>

-const u8 mainboard_picr_data[FCH_INT_TABLE_SIZE] = {
+static const u8 mainboard_picr_data[FCH_INT_TABLE_SIZE] = {
    /* INTA# - INTH# */
    [0x00] = 0x03,0x04,0x05,0x07,0x0B,0x0A,0x1F,0x1F,
    /* Misc-nil,0,1,2, INT from Serial irq */
@@ -38,7 +38,7 @@
    [0x40] = 0x04, 0x04
 };

-const u8 mainboard_intr_data[FCH_INT_TABLE_SIZE] = {
+static const u8 mainboard_intr_data[FCH_INT_TABLE_SIZE] = {
    /* INTA# - INTH# */
    [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,
    /* Misc-nil,0,1,2, INT from Serial irq */
diff --git a/src/mainboard/gizmosphere/gizmo2/mainboard.c b/src/mainboard/gizmosphere/gizmo2/mainboard.c
index f856df9..a6c1a6d 100644
--- a/src/mainboard/gizmosphere/gizmo2/mainboard.c
+++ b/src/mainboard/gizmosphere/gizmo2/mainboard.c
@@ -33,7 +33,7 @@
  * These values are used by the PCI configuration space,
  * MP Tables.  TODO: Make ACPI use these values too.
  */
-const u8 mainboard_picr_data[FCH_INT_TABLE_SIZE] = {
+static const u8 mainboard_picr_data[FCH_INT_TABLE_SIZE] = {
    /* INTA# - INTH# */
    [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,
    /* Misc-nil,0,1,2, INT from Serial irq */
@@ -48,7 +48,7 @@
    [0x41] = 0x0F,
 };

-const u8 mainboard_intr_data[FCH_INT_TABLE_SIZE] = {
+static const u8 mainboard_intr_data[FCH_INT_TABLE_SIZE] = {
    /* INTA# - INTH# */
    [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,
    /* Misc-nil,0,1,2, INT from Serial irq */
diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c
index 0173064..42a82d4 100644
--- a/src/mainboard/google/kahlee/mainboard.c
+++ b/src/mainboard/google/kahlee/mainboard.c
@@ -45,7 +45,7 @@
  * MP Tables.  TODO: Make ACPI use these values too.
  */

-const u8 mainboard_picr_data[] = {
+static const u8 mainboard_picr_data[] = {
    [0x00] = 0x03, 0x04, 0x05, 0x07, 0x0B, 0x1F, 0x1F, 0x1F,
    [0x08] = 0xFA, 0xF1, 0x00, 0x00, 0x1F, 0x1F, 0x1F, 0x1F,
    [0x10] = 0x09, 0x1F, 0x1F, 0x03, 0x1F, 0x1F, 0x1F, 0x03,
@@ -64,7 +64,7 @@
    [0x78] = 0x1F, 0x1F, 0x1F, 0x1F, 0x1F, 0x1F, 0x1F, 0x1F,
 };

-const u8 mainboard_intr_data[] = {
+static const u8 mainboard_intr_data[] = {
    [0x00] = 0x10, 0x11, 0x12, 0x13, 0x14, 0x1F, 0x16, 0x17,
    [0x08] = 0x00, 0x00, 0x00, 0x00, 0x1F, 0x1F, 0x1F, 0x1F,
    [0x10] = 0x09, 0x1F, 0x1F, 0x10, 0x1F, 0x1F, 0x1F, 0x10,