Attention is currently required from: Maulik V Vaghela, Subrata Banik, Angel Pons, Patrick Rudolph.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59310 )
Change subject: soc/intel/../thermal: Use `clrsetbits32` API for setting LTT
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59310/comment/f969711f_4da82f99
PS7, Line 7: soc/intel/../thermal: Use `clrsetbits32` API for setting LTT
I suggest:
soc/intel/common/thermal: Use `clrsetbits32()` for setting LTT
Or this:
soc/intel/common/thermal: Clean up code using `clrsetbits32()`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59310
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51fea7bd2146ea29ef476218c006f7350b32c006
Gerrit-Change-Number: 59310
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 19 Nov 2021 19:12:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment